Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/payload commit port #45

Merged
merged 4 commits into from
Nov 7, 2023
Merged

Feat/payload commit port #45

merged 4 commits into from
Nov 7, 2023

Conversation

anomit
Copy link
Member

@anomit anomit commented Nov 3, 2023 •
edited
Loading

Fixes #44

Checklist

  • My branch is up-to-date with upstream/main branch.
  • Everything works and tested for major version of Python/NodeJS/Go and above.
  • I ran pre-commit checks against my changes.
  • I've written tests against my changes and all the current present tests are passing.

Current behaviour

Described in #44

New expected behaviour

Described in #44

Change logs

Changed

  • Snapshot finalized events are now handled for the current epoch instead of a epochId - 1 delay
  • Cleaner task handler for RabbitMQ messages sent from snapshotter as well as SnapshotFinalized events forwarded to it
  • requirements of minimum uptime and maximum restarts now removed from pm2 config file since these are handled as part of deploy bundles

Changed payload commit service workflow

  • Inefficient, memory hungry fetches and traversal over entirety of snapshot zsets in Redis
  • IPFS and web3 storage upload features

Deployment Instructions

NA

@anomit anomit requested a review from xadahiya November 3, 2023 07:22
@anomit anomit self-assigned this Nov 3, 2023
@anomit anomit marked this pull request as ready for review November 7, 2023 12:53
xadahiya
xadahiya approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@xadahiya xadahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in one of the stg instances, running as expected without any issues. LGTM!

@xadahiya xadahiya merged commit eebc0c9 into main Nov 7, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xadahiya xadahiya xadahiya approved these changes

Assignees

@anomit anomit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove IPFS and web3 storage upload functionalities
2 participants
@anomit @xadahiya