Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: disable retries on HTTP requests #43

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Conversation

anomit
Copy link
Member

@anomit anomit commented Nov 2, 2023

Checklist

  • My branch is up-to-date with upstream/main branch.
  • Everything works and tested for major version of Python/NodeJS/Go and above.
  • I ran pre-commit checks against my changes.
  • I've written tests against my changes and all the current present tests are passing.

Current behaviour

Presently the Audit Protocol services use a retryable HTTP package which is redundant and often over consumes resources along with causing memory leakage issues.

New expected behaviour

HTTP requests are not retried since the components which handle them have built in redundancy, load balancing and retires.

Deployment Instructions

NA

@anomit anomit requested a review from xadahiya November 2, 2023 09:01
@anomit anomit self-assigned this Nov 2, 2023
Copy link
Member

@xadahiya xadahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on multiple stg instances, LGTM!

@xadahiya xadahiya merged commit 7597202 into main Nov 2, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants