feat: allow labels to bump patch/minor versions #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmarticus
approved these changes
Aug 8, 2024
Comment on lines
+39
to
+46
| if [ "${{ steps.bump-type.outputs.type }}" == "minor" ]; then | ||
| new_version="$major.$((minor + 1)).0" | ||
| else | ||
| new_version="$major.$minor.$((patch + 1))" | ||
| fi | ||
|
|
||
| sed -i "s/const Version = \"$current_version\"/const Version = \"$new_version\"/" version.go | ||
| echo "::set-output name=new_version::$new_version" |
There was a problem hiding this comment.
deploy scripts always look so dastardly; I love it.
Comment on lines
+23
to
+28
| run: | | ||
| if [[ $(GITHUB_TOKEN=${{ secrets.POSTHOG_BOT_GITHUB_TOKEN }} gh pr view ${{ github.event.pull_request.number }} --json labels -q '.labels[].name' | grep -q "minor") ]]; then | ||
| echo "type=minor" >> $GITHUB_OUTPUT | ||
| else | ||
| echo "type=patch" >> $GITHUB_OUTPUT | ||
| fi |
There was a problem hiding this comment.
good call not supporting major version bumps; I don't want to deal with v2 yet.
There was a problem hiding this comment.
1000% - that will be a manual process anyways
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to make sure that every land to master bumps the version so people can pin a version with confidence. This allows that.