Support multiple cohorts in local evaluation #34
Conversation
> 3. There's more than one cohort in the feature flag definition. This restriction is annoying. And it seems it could be resolved rather easily. Copying what NodeJS SDK does. Ref: https://posthog.com/docs/feature-flags/local-evaluation
|
This is excellent, thanks @zaynetro , will review shortly |
|
|
||
| require ( | ||
| github.com/google/uuid v1.3.0 | ||
| github.com/urfave/cli v1.22.5 | ||
| ) | ||
|
|
||
| require ( | ||
| github.com/cpuguy83/go-md2man/v2 v2.0.0-20190314233015-f79a8a8ca69d // indirect |
There was a problem hiding this comment.
these are a bit sus, what are they used for? 🤔
There was a problem hiding this comment.
I just ran go mod tidy. This seems to be a dependency of github.com/urfave/cli.
|
Hi! Do you plan on merging this soonish? Is there something I can help with? |
|
Sorry was off sick with a bad cold, didn't write a proper note on the approval. I'm just going to test this version with cohorts with a real project, and merge when all still looks good! Thanks again for doing this :) |
|
All good here :) - I found a separate issue where non-integer rollout percentages bork unmarshalling, but nothing related to this 👍 |
|
Thanks @zaynetro for all your recent contributions. I'd love to send you a posthog merch code, could you send me an email at neil @ posthog . com ? |
This restriction is annoying. Copying what NodeJS SDK does.
Ref: https://posthog.com/docs/feature-flags/local-evaluation
PS Sorry I couldn't reopen my old PR somehow :/