Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log flag name when failed to compute it locally #32

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

zaynetro
Copy link
Contributor

@zaynetro zaynetro commented Feb 8, 2024

Atm it is impossible to tell which flag failed to be computed locally.

Before:

Unable to compute flag locally - Can't determine if feature flag is enabled or not with given properties

After:

Unable to compute flag locally (my_test) - Can't determine if feature flag is enabled or not with given properties

Atm it is impossible to tell which flag failed to be computed locally.

Before:

```
Unable to compute flag locally - Can't determine if feature flag is enabled or not with given properties
```

After:

```
Unable to compute flag locally (my_test) - Can't determine if feature flag is enabled or not with given properties
```
@neilkakkar neilkakkar merged commit abe6962 into PostHog:master Feb 8, 2024
1 check passed
@zaynetro zaynetro deleted the local-eval-log-flag-key branch February 8, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants