Skip to content

Commit

Permalink
remove TODO
Browse files Browse the repository at this point in the history
  • Loading branch information
neilkakkar committed Mar 27, 2024
1 parent 9dd87a7 commit 13fdc0d
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions feature_flags_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -617,13 +617,9 @@ func TestFeatureFlagNullComeIntoPlayOnlyWhenDecideErrorsOut(t *testing.T) {

defer server.Close()

// TODO: Make this nicer, right now if all local evaluation requests fail, we block
// on waiting for atleast one request to happen before returning flags,
// which can be suboptimal
client, _ := NewWithConfig("Csyjlnlun3OzyNJAafdlv", Config{
PersonalApiKey: "some very secret key",
Endpoint: server.URL,
DefaultFeatureFlagsPollingInterval: 5 * time.Second,
PersonalApiKey: "some very secret key",
Endpoint: server.URL,
})
defer client.Close()

Expand Down

0 comments on commit 13fdc0d

Please sign in to comment.