Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MockInteractions.track to provide correct step values #60

Closed

Conversation

txsmith
Copy link

@txsmith txsmith commented Jun 27, 2016

Fixes #59, the delta computations in the move function were the wrong way around.

Also get rid of the setTimeout call in the test suite since Polymer/polymer#3540 is resolved

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@txsmith
Copy link
Author

txsmith commented Jun 27, 2016

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@txsmith
Copy link
Author

txsmith commented Feb 20, 2017

Could you give an indication on whether this is likely to be accepted in the near future?

@txsmith txsmith closed this by deleting the head repository Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MockInteractions.track passes incorrect delta values
2 participants