Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fix #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Minor fix #37

wants to merge 1 commit into from

Conversation

MeTaNoV
Copy link

@MeTaNoV MeTaNoV commented Apr 2, 2016

Since the function is defined in the observers array, no old value will be added.

Q: since selected is also not used, should we remove it from the function parameter?

@MeTaNoV
Minor fix
c74491a 
Since the function is defined in the observers array, no old value will be added.

Q: since selected is also not used, should we remove it from the function parameter?
stramel
stramel approved these changes May 4, 2017
View reviewed changes
Copy link

@stramel stramel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

May be good to just remove all params since they aren't used?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stramel stramel stramel approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MeTaNoV @stramel @googlebot