Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

DOMs : Add schema to complete the text explanation #1690

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alemarre
Copy link

Hi,
The text explanation was a bit confusing for me at the first read (a lot a "new" terms : local dom, light dom, shadow dom, shady dom)
I think a schema could help understanding

Hi, 
The text explanation was a bit confusing for me at the first read (a lot a "new" terms  : local dom, light dom, shadow dom, shady dom)
I think a schema could help understanding
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@alemarre
Copy link
Author

I signed it

@googlebot
Copy link

CLAs look good, thanks!

- Shady DOM (Polymer implementation)
-->

<content>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<content> should be <slot> now...

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a suggested edit to a 1.0 doc so it should stay <content>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so we should keep it <content> even though 1.7+ can make use of slots and reduces changes going to 2.0?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¯_(ツ)_/¯ Or note hybrid syntax?

- Shady DOM (Polymer implementation)
-->

<content>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a suggested edit to a 1.0 doc so it should stay <content>


</template>
</dom-module>
```
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something seems not quite right about this. I will try to explain my thoughts.

I read the the comments in the <template> section as instructing me to insert my own code here, and that my code must be either:

  • A "Shadow DOM (browser implementation)", or
  • A "Shady DOM (Polymer implementation)"

I would not know what either of these things are, or how to write them.

Thus I find this suggested addition to be more confusing rather than clarifying.

But I will ask @arthurevans to comment here and will trust his opinion on the matter.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants