Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle transformed HTML at the root route. #30

Merged
merged 2 commits into from
Jul 6, 2020
Merged

Handle transformed HTML at the root route. #30

merged 2 commits into from
Jul 6, 2020

Conversation

usergenic
Copy link
Collaborator

Fixes the case described by @kevinpschaaf in #16 where HTML served at the root route resulted in failures to resolve module specifiers. Thanks for the in-depth look, @kevinpschaaf

@usergenic usergenic changed the title Root route Handle transformed HTML at the root route. Jul 6, 2020
@usergenic usergenic self-assigned this Jul 6, 2020
@usergenic usergenic added the Type: Bug Something isn't working label Jul 6, 2020
@usergenic usergenic mentioned this pull request Jul 6, 2020
Open
@usergenic
Copy link
Collaborator Author

Thanks @aomarks

@usergenic usergenic merged commit 7add2c3 into master Jul 6, 2020
@usergenic usergenic deleted the root-route branch July 6, 2020 17:34
@usergenic
Copy link
Collaborator Author

@aomarks @kevinpschaaf I just published [email protected] 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aomarks aomarks aomarks approved these changes

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf

Assignees

@usergenic usergenic

Labels
Type: Bug Something isn't working Unplanned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@usergenic @aomarks