Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DIY Fig 1 notebook more approachable #52

Merged
merged 3 commits into from
Dec 8, 2023
Merged

Conversation

Swanson-Hysell
Copy link
Member

More explanations are added within the markdown cells and it is articulated which parameters should be changed. The plotting function was also modified to be more flexible to different variable choices (rather than be tailored to those plotted in Figure 1 of the manuscript).

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b894fcd) 87.04% compared to head (6531c54) 87.04%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #52   +/-   ##
=======================================
  Coverage   87.04%   87.04%           
=======================================
  Files           9        9           
  Lines         301      301           
=======================================
  Hits          262      262           
  Misses         39       39           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@facusapienza21 facusapienza21 merged commit ded8cb9 into main Dec 8, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants