Enable USE_UMFPACK in surface module on macOS CI #6078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cybaol
force-pushed
the
enable-USE_UMFPACK-on-macos-ci
branch
from
964462d
to
bdc9ab5
Compare
larshg
reviewed
Aug 27, 2024
| @@ -293,6 +293,13 @@ endif() | |||
| # OpenMP (optional) | |||
| option(WITH_OPENMP "Build with parallelization using OpenMP" TRUE) | |||
| if(WITH_OPENMP) | |||
| if(APPLE) | |||
There was a problem hiding this comment.
Can you remove this change from this PR?
There was a problem hiding this comment.
What if you try remove the local findOpenMP and use the one from Cmake itself, as in #6100?
larshg
reviewed
Aug 27, 2024
| else | ||
| leaf_count += node->m_count; | ||
| } | ||
| // static void NodeCountHelper( const ON_RTreeNode* node, std::size_t& node_count, std::size_t& wasted_branch_count, std::size_t& leaf_count ) |
There was a problem hiding this comment.
Lets just remove this, if you think its not of use?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.