fix(publisher): fix splitRepoAndTag function

[wuhuizuo]

This pull request includes a small but important change to the splitRepoAndTag function in the publisher/pkg/tiup/funcs.go file. The change corrects the logic for determining the delimiter used to split the repository and tag in a given URL.

• publisher/pkg/tiup/funcs.go: Modified the splitRepoAndTag function to correctly identify URLs containing @sha256: and use the appropriate delimiter for splitting.

Signed-off-by: wuhuizuo [email protected]

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and description, it seems that the changes in this pull request are related to fixing a function named splitRepoAndTag in the publisher/pkg/tiup/funcs.go file.

The actual change in the code is a minor modification in line 240, where a conditional statement is inverted to check if the provided URL contains @sha256: instead of the previous check of not containing it.

Regarding potential problems, it seems that the change is straightforward and does not introduce any significant issues. However, it would be helpful to ensure that the change does not affect any other parts of the codebase that rely on the splitRepoAndTag function.

As for fixing suggestions, I would suggest conducting a more comprehensive test to ensure that the changes do not create any unforeseen issues. Additionally, the pull request could benefit from a more detailed description of the changes made and their impact.

[wuhuizuo]

/approve

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [wuhuizuo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment