Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perlop: fix and normalize indentation and alignment #22658

Open
wants to merge 1 commit into
base: blead
Choose a base branch
from

Conversation

haarg
Copy link
Contributor

@haarg haarg commented Oct 10, 2024

Tabs for alignment don't work well in verbatim sections. The indentation of the code may be stripped when being displayed, resulting in the tab alignment not matching the intention. This can currently be seen on https://metacpan.org/pod/perlop and https://perldoc.perl.org/perlop

Since most of the code uses 4 space indents, normalize all of the indentation to use 4 spaces.

Copy link
Contributor

@leonerd leonerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkeenan
Copy link
Contributor

jkeenan commented Oct 10, 2024

This cannot be merged as is. It fails the t/porting/podcheck.t. See end of https://github.com/Perl/perl5/actions/runs/11281442619/job/31376683077?pr=22658 for options on fixing, run make test_porting before re-pushing. Thanks.

@haarg haarg force-pushed the haarg/perlop-fix-improve-indent-alignment branch from bcea459 to 997089d Compare October 10, 2024 23:06
Tabs for alignment don't work well in verbatim sections. The indentation
of the code may be stripped when being displayed, resulting in the tab
alignment not matching the intention. This can currently be seen on
https://metacpan.org/pod/perlop and https://perldoc.perl.org/perlop

Since most of the code uses 4 space indents, normalize all of the
indentation to use 4 spaces.
@haarg haarg force-pushed the haarg/perlop-fix-improve-indent-alignment branch from 997089d to 8684cb8 Compare October 10, 2024 23:26
Copy link
Contributor

@jkeenan jkeenan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make test_porting now passing. Recommend squash before merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants