no bareword_filehandes: don't look up class barewords as handles #21161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't believe this belongs in 5.38 at this stage, it may change the behaviour of working code. |
tonycoz
added
the
defer-next-dev
jkeenan
removed
the
defer-next-dev
tonycoz
force-pushed
the
19426-bareword-io-method
branch
from
503d7c8
to
f4cacbd
Compare
tonycoz
force-pushed
the
19426-bareword-io-method
branch
from
f4cacbd
to
03ee603
Compare
@tonycoz, do you still want to pursue this p.r. (now that we're past 5.38.0)? If so, you will need to resolve some conflicts. Thanks. |
tonycoz
force-pushed
the
19426-bareword-io-method
branch
from
03ee603
to
a313e49
Compare
|
Rebased, waiting for review, preferably on both the behaviour and the implementation. |
leonerd
reviewed
Feb 18, 2024
|
Added one comment about the implementation, but I think overall the intent of the behaviour is good. It means that with that feature enabled, the behaviour of "Name->foo" is simpler to explain and reason about, because it doesn't depend on (dynamic) filehandle setup any more. |
This prevents SomeBareword from being looked up as a filehandle: no feature "bareword_filehandles"; SomeBareword->method(); Since "bareword_filehandles" is explicitly about bareword handles, it does not prevent other string to object/class look ups from resolving the class as a filehandle, eg for the following: "SomeLiteral"->method(); my $x = "SomeVariable"; $x->method(); both are looked up as file handles per normal. Note that in any of these cases, with or without the bareword_filehandles feature, if the name is a bareword that has been resolved as a class name since the last time the stash cache was cleared, it will be resolved as a class name, not a filehandle. Fixes Perl#19426 # Conflicts: # opcode.h # Conflicts: # opcode.h
tonycoz
force-pushed
the
19426-bareword-io-method
branch
from
a313e49
to
0d39edb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents SomeBareword from being looked up as a filehandle:
no feature "bareword_filehandles";
SomeBareword->method();
Since "bareword_filehandles" is explicitly about bareword handles, it does not prevent other string to object/class look ups from resolving the class as a filehandle, eg for the following:
"SomeLiteral"->method();
my $x = "SomeVariable";
$x->method();
both are looked up as file handles per normal.
Note that in any of these cases, with or without the bareword_filehandles feature, if the name is a bareword that has been resolved as a class name since the last time the stash cache was cleared, it will be resolved as a class name, not a filehandle.
Fixes #19426