21332 Dissolutions job - Update filer config (bcgov#2793)

* Add unit tests * Fix unit tests * Update config for involuntary dissolutions job * Fix typos * Fix accidental makefile change
PaulGarewal · Jun 28, 2024 · 2685686 · 2685686
1 parent e58ba1a
commit 2685686
Show file tree

Hide file tree

Showing 22 changed files with 24 additions and 20 deletions.
diff --git a/colin-api/Makefile b/colin-api/Makefile
@@ -45,7 +45,7 @@ build-req: clean ## Upgrade requirements
 	cat requirements/bcregistry-libraries.txt >> requirements.txt ;\
 	pip install -Ur requirements/bcregistry-libraries.txt
 
-install: clean ## Install python virtrual environment
+install: clean ## Install python virtual environment
 	test -f venv/bin/activate || python3.8 -m venv  $(CURRENT_ABS_DIR)/venv ;\
 	. venv/bin/activate ;\
 	pip install --upgrade pip ;\

diff --git a/data-reset-tool/Makefile b/data-reset-tool/Makefile
@@ -45,7 +45,7 @@ build-req: clean ## Upgrade requirements
 	cat requirements/bcregistry-libraries.txt >> requirements.txt ;\
 	pip install -Ur requirements/bcregistry-libraries.txt
 
-install: clean ## Install python virtrual environment
+install: clean ## Install python virtual environment
 	test -f venv/bin/activate || python3.8 -m venv  $(CURRENT_ABS_DIR)/venv ;\
 	. venv/bin/activate ;\
 	pip install pip==20.1.1 ;\

diff --git a/data-tool/Makefile b/data-tool/Makefile
@@ -45,7 +45,7 @@ build-req: clean ## Upgrade requirements
 	cat requirements/bcregistry-libraries.txt >> requirements.txt ;\
 	pip install -Ur requirements/bcregistry-libraries.txt
 
-install: clean ## Install python virtrual environment
+install: clean ## Install python virtual environment
 	test -f venv/bin/activate || python3.11 -m venv  $(CURRENT_ABS_DIR)/venv ;\
 	. venv/bin/activate ;\
 	pip install --upgrade pip ;\

diff --git a/jobs/email-reminder/Makefile b/jobs/email-reminder/Makefile
@@ -45,7 +45,7 @@ build-req: clean ## Upgrade requirements
 	cat requirements/bcregistry-libraries.txt >> requirements.txt ;\
 	pip install -Ur requirements/bcregistry-libraries.txt
 
-install: clean ## Install python virtrual environment
+install: clean ## Install python virtual environment
 	test -f venv/bin/activate || python3.8 -m venv  $(CURRENT_ABS_DIR)/venv ;\
 	. venv/bin/activate ;\
 	pip install pip==20.1.1 ;\

diff --git a/jobs/filings-notebook-report/Makefile b/jobs/filings-notebook-report/Makefile
@@ -49,7 +49,7 @@ build-req: clean ## Upgrade requirements
 	pip install -Ur requirements/prod.txt ;\
 	pip freeze | sort > requirements.txt ;\
 
-install: clean ## Install python virtrual environment
+install: clean ## Install python virtual environment
 	test -f venv/bin/activate || python3.8 -m venv  $(CURRENT_ABS_DIR)/venv ;\
 	. venv/bin/activate ;\
 	pip install pip==21.1.2 ;\

diff --git a/jobs/furnishings/Makefile b/jobs/furnishings/Makefile
@@ -45,7 +45,7 @@ build-req: clean ## Upgrade requirements
 	cat requirements/bcregistry-libraries.txt >> requirements.txt ;\
 	pip install -Ur requirements/bcregistry-libraries.txt
 
-install: clean ## Install python virtrual environment
+install: clean ## Install python virtual environment
 	test -f venv/bin/activate || python3.8 -m venv  $(CURRENT_ABS_DIR)/venv ;\
 	. venv/bin/activate ;\
 	pip install pip==20.1.1 ;\

diff --git a/jobs/future-effective-filings/Makefile b/jobs/future-effective-filings/Makefile
@@ -45,7 +45,7 @@ build-req: clean ## Upgrade requirements
 	cat requirements/bcregistry-libraries.txt >> requirements.txt ;\
 	pip install -Ur requirements/bcregistry-libraries.txt
 
-install: clean ## Install python virtrual environment
+install: clean ## Install python virtual environment
 	test -f venv/bin/activate || python3.8 -m venv  $(CURRENT_ABS_DIR)/venv ;\
 	. venv/bin/activate ;\
 	pip install pip==20.1.1 ;\

diff --git a/jobs/involuntary-dissolutions/Makefile b/jobs/involuntary-dissolutions/Makefile
@@ -45,7 +45,7 @@ build-req: clean ## Upgrade requirements
 	cat requirements/bcregistry-libraries.txt >> requirements.txt ;\
 	pip install -Ur requirements/bcregistry-libraries.txt
 
-install: clean ## Install python virtrual environment
+install: clean ## Install python virtual environment
 	test -f venv/bin/activate || python3.8 -m venv  $(CURRENT_ABS_DIR)/venv ;\
 	. venv/bin/activate ;\
 	pip install pip==20.1.1 ;\

diff --git a/jobs/involuntary-dissolutions/config.py b/jobs/involuntary-dissolutions/config.py
@@ -53,6 +53,7 @@ class _Config(object):  # pylint: disable=too-few-public-methods
     NATS_SERVERS = os.getenv('NATS_SERVERS', None)
     NATS_CLUSTER_ID = os.getenv('NATS_CLUSTER_ID', None)
     NATS_CLIENT_NAME = os.getenv('NATS_CLIENT_NAME', None)
+    NATS_FILER_SUBJECT = os.getenv('NATS_FILER_SUBJECT', 'entity.filer')
     NATS_ENTITY_EVENTS_SUBJECT = os.getenv('NATS_ENTITY_EVENTS_SUBJECT', 'entity.events')
 
     SECRET_KEY = 'a secret'

diff --git a/jobs/involuntary-dissolutions/involuntary_dissolutions.py b/jobs/involuntary-dissolutions/involuntary_dissolutions.py
@@ -123,6 +123,9 @@ async def put_filing_on_queue(filing_id: int, app: Flask, qsm: QueueService):
             f'Queue Error: Failed to place filing {filing_id} on Queue with error:{err}',
             level='error'
         )
+        app.logger.error(
+            f'Queue Error: Failed to place filing {filing_id} on Queue with error:{err}'
+        )
 
 
 def mark_eligible_batches_completed():

diff --git a/jobs/sftp-gazette/Makefile b/jobs/sftp-gazette/Makefile
@@ -49,7 +49,7 @@ build-req: clean ## Upgrade requirements
 	pip install -Ur requirements/prod.txt ;\
 	pip freeze | sort > requirements.txt ;\
 
-install: clean ## Install python virtrual environment
+install: clean ## Install python virtual environment
 	test -f venv/bin/activate || python3.8 -m venv  $(CURRENT_ABS_DIR)/venv ;\
 	. venv/bin/activate ;\
 	pip install pip==21.1.2 ;\

diff --git a/jobs/sftp-icbc-report/Makefile b/jobs/sftp-icbc-report/Makefile
@@ -50,7 +50,7 @@ build-req: clean ## Upgrade requirements
 	pip install -Ur requirements/prod.txt ;\
 	pip freeze | sort > requirements.txt ;\
 
-install: clean ## Install python virtrual environment
+install: clean ## Install python virtual environment
 	test -f venv/bin/activate || python3.8 -m venv  $(CURRENT_ABS_DIR)/venv ;\
 	. venv/bin/activate ;\
 	pip install pip==21.1.2 ;\

diff --git a/jobs/sftp-nuans-report/Makefile b/jobs/sftp-nuans-report/Makefile
@@ -49,7 +49,7 @@ build-req: clean ## Upgrade requirements
 	pip install -Ur requirements/prod.txt ;\
 	pip freeze | sort > requirements.txt ;\
 
-install: clean ## Install python virtrual environment
+install: clean ## Install python virtual environment
 	test -f venv/bin/activate || python3.8 -m venv  $(CURRENT_ABS_DIR)/venv ;\
 	. venv/bin/activate ;\
 	pip install pip==21.1.2 ;\

diff --git a/jobs/update-colin-filings/Makefile b/jobs/update-colin-filings/Makefile
@@ -45,7 +45,7 @@ build-req: clean ## Upgrade requirements
 	cat requirements/bcregistry-libraries.txt >> requirements.txt ;\
 	pip install -Ur requirements/bcregistry-libraries.txt
 
-install: clean ## Install python virtrual environment
+install: clean ## Install python virtual environment
 	test -f venv/bin/activate || python3.8 -m venv  $(CURRENT_ABS_DIR)/venv ;\
 	. venv/bin/activate ;\
 	pip install --upgrade pip ;\

diff --git a/jobs/update-legal-filings/Makefile b/jobs/update-legal-filings/Makefile
@@ -45,7 +45,7 @@ build-req: clean ## Upgrade requirements
 	cat requirements/bcregistry-libraries.txt >> requirements.txt ;\
 	pip install -Ur requirements/bcregistry-libraries.txt
 
-install: clean ## Install python virtrual environment
+install: clean ## Install python virtual environment
 	test -f venv/bin/activate || python3.8 -m venv  $(CURRENT_ABS_DIR)/venv ;\
 	. venv/bin/activate ;\
 	pip install pip==20.1.1 ;\

diff --git a/legal-api/Makefile b/legal-api/Makefile
@@ -45,7 +45,7 @@ build-req: clean ## Upgrade requirements
 	cat requirements/bcregistry-libraries.txt >> requirements.txt ;\
 	pip install -Ur requirements/bcregistry-libraries.txt
 
-install: clean ## Install python virtrual environment
+install: clean ## Install python virtual environment
 	test -f venv/bin/activate || python3 -m venv  $(CURRENT_ABS_DIR)/venv ;\
 	. venv/bin/activate ;\
 	pip install --upgrade pip ;\

diff --git a/queue_services/business-pay/Makefile b/queue_services/business-pay/Makefile
@@ -45,7 +45,7 @@ build-req: clean ## Upgrade requirements
 	cat requirements/bcregistry-libraries.txt >> requirements.txt ;\
 	pip install -Ur requirements/bcregistry-libraries.txt
 
-install: clean ## Install python virtrual environment
+install: clean ## Install python virtual environment
 	test -f venv/bin/activate || python3 -m venv  $(CURRENT_ABS_DIR)/venv ;\
 	. venv/bin/activate ;\
 	pip install pip==20.1.1 ;\

diff --git a/queue_services/common/Makefile b/queue_services/common/Makefile
@@ -44,7 +44,7 @@ build-req: clean ## Upgrade requirements
 	cat requirements/bcregistry-libraries.txt >> requirements.txt ;\
 	pip install -Ur requirements/bcregistry-libraries.txt
 
-install: clean ## Install python virtrual environment
+install: clean ## Install python virtual environment
 	test -f venv/bin/activate || python3.8 -m venv  $(CURRENT_ABS_DIR)/venv ;\
 	. venv/bin/activate ;\
 	pip install pip==20.1.1 ;\

diff --git a/queue_services/entity-bn/Makefile b/queue_services/entity-bn/Makefile
@@ -45,7 +45,7 @@ build-req: clean ## Upgrade requirements
 	cat requirements/bcregistry-libraries.txt >> requirements.txt ;\
 	pip install -Ur requirements/bcregistry-libraries.txt
 
-install: clean ## Install python virtrual environment
+install: clean ## Install python virtual environment
 	test -f venv/bin/activate || python3 -m venv  $(CURRENT_ABS_DIR)/venv ;\
 	. venv/bin/activate ;\
 	pip install --upgrade pip ;\

diff --git a/queue_services/entity-digital-credentials/Makefile b/queue_services/entity-digital-credentials/Makefile
@@ -45,7 +45,7 @@ build-req: clean ## Upgrade requirements
 	cat requirements/bcregistry-libraries.txt >> requirements.txt ;\
 	pip install -Ur requirements/bcregistry-libraries.txt
 
-install: clean ## Install python virtrual environment
+install: clean ## Install python virtual environment
 	test -f venv/bin/activate || python3.8 -m venv  $(CURRENT_ABS_DIR)/venv ;\
 	. venv/bin/activate ;\
 	pip install upgrade pip ;\

diff --git a/queue_services/entity-emailer/Makefile b/queue_services/entity-emailer/Makefile
@@ -45,7 +45,7 @@ build-req: clean ## Upgrade requirements
 	cat requirements/bcregistry-libraries.txt >> requirements.txt ;\
 	pip install -Ur requirements/bcregistry-libraries.txt
 
-install: clean ## Install python virtrual environment
+install: clean ## Install python virtual environment
 	test -f venv/bin/activate || python3.8 -m venv  $(CURRENT_ABS_DIR)/venv ;\
 	. venv/bin/activate ;\
 	pip install pip==20.1.1 ;\

diff --git a/queue_services/entity-pay/Makefile b/queue_services/entity-pay/Makefile
@@ -45,7 +45,7 @@ build-req: clean ## Upgrade requirements
 	cat requirements/bcregistry-libraries.txt >> requirements.txt ;\
 	pip install -Ur requirements/bcregistry-libraries.txt
 
-install: clean ## Install python virtrual environment
+install: clean ## Install python virtual environment
 	test -f venv/bin/activate || python3.8 -m venv  $(CURRENT_ABS_DIR)/venv ;\
 	. venv/bin/activate ;\
 	pip install pip==20.1.1 ;\