Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a
guard skill mode
config, allowing guard skills to be scaled by uptime, separately for EHP and for Max Hit.The default is average for EHP, and disabled for Max Hit, with options for
Average / Disabled
,Maximum / Disabled
,Average / Maximum
andMaximum / Maximum
. I considered adding options for allowing max hit to use an average mode, and thus has been implemented on the backend, just not as options in the config due to the extra clutter it would add compared to how often it would be used, this can be revised at a later date.Immortal call is not scaled by this setting, and thus is now automatically disabled on import, as scaling this ended up really messy as I needed to add extra stats for the scaled and unscaled damage reduction of it. It does however also scale vaal arctic armour, as that was commonly used for large max hit with no proper uptime.
This still heavily undervalues guard skills for very large EHP, where you can survive long enough to get multiple uses of the skill, but that will be fixed elsewhere.
This also adds a note to the sidebar EHP if guardskills are being applied
This adds the same note regardless if its scaled by uptime or not, as it gets too long to differentiate them, and does not add the note for immortal call. I can possibly also add this note to the max hits.