Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Guard Skill Mode #8343

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

Regisle
Copy link
Member

@Regisle Regisle commented Oct 22, 2024

This implements a guard skill mode config, allowing guard skills to be scaled by uptime, separately for EHP and for Max Hit.

The default is average for EHP, and disabled for Max Hit, with options for Average / Disabled, Maximum / Disabled, Average / Maximum and Maximum / Maximum. I considered adding options for allowing max hit to use an average mode, and thus has been implemented on the backend, just not as options in the config due to the extra clutter it would add compared to how often it would be used, this can be revised at a later date.

Immortal call is not scaled by this setting, and thus is now automatically disabled on import, as scaling this ended up really messy as I needed to add extra stats for the scaled and unscaled damage reduction of it. It does however also scale vaal arctic armour, as that was commonly used for large max hit with no proper uptime.

This still heavily undervalues guard skills for very large EHP, where you can survive long enough to get multiple uses of the skill, but that will be fixed elsewhere.

This also adds a note to the sidebar EHP if guardskills are being applied
image

This adds the same note regardless if its scaled by uptime or not, as it gets too long to differentiate them, and does not add the note for immortal call. I can possibly also add this note to the max hits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant