Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prettify the the diagnostic file content #5685

Merged
merged 3 commits into from
Jul 28, 2020
Merged

Prettify the the diagnostic file content #5685

merged 3 commits into from
Jul 28, 2020

Conversation

HEskandari
Copy link
Contributor

@HEskandari HEskandari commented Jul 21, 2020 •
edited
Loading

Connects to #5050

Prettifies the output of the Diagnostics file. This makes the diagnostic file more readable.

@CLAassistant
Copy link

CLAassistant commented Jul 21, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

mikeminutillo
mikeminutillo requested changes Jul 22, 2020
View reviewed changes
Copy link
Member

@mikeminutillo mikeminutillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we put some unit tests (maybe approval tests) around the JsonPrettyPrinter? Especially the quoting rules.

@HEskandari
Copy link
Contributor Author

@mikeminutillo added some tests, which revealed a corner case. Bug is fixed and approval tests are pushed.

@WojcikMike WojcikMike merged commit 81288b7 into master Jul 28, 2020
@WojcikMike WojcikMike deleted the readable-diagnostics branch July 28, 2020 12:49
@WojcikMike WojcikMike added this to the 7.4.0 milestone Jul 28, 2020
@mikeminutillo mikeminutillo linked an issue Jul 29, 2020 that may be closed by this pull request
Start up diagnostics aren't human readable #5050
Closed
@HEskandari HEskandari changed the title add json prettifier for the diagnostic file Prettify the the diagnostic file content Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeminutillo mikeminutillo mikeminutillo approved these changes

@WojcikMike WojcikMike WojcikMike approved these changes

Assignees
No one assigned
Labels
Improvement
Projects
None yet
Milestone
7.4.0
Development

Successfully merging this pull request may close these issues.

Start up diagnostics aren't human readable
4 participants
@HEskandari @CLAassistant @mikeminutillo @WojcikMike