Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Podcast.publish! on change #721

Merged
merged 2 commits into from
Jul 26, 2023
Merged

Podcast.publish! on change #721

merged 2 commits into from
Jul 26, 2023

Conversation

cavis
Copy link
Member

@cavis cavis commented Jul 26, 2023

Oversight: forgot to call podcast.publish! to write the updated RSS feed.

This logic was in several other places:

  1. All the API controllers already did this, calling publish! on the podcast in an after_action hook
    • TODO: should the episode APIs be publishing the episode, instead of the podcast???
  2. Feed images will publish! the podcast when the status becomes complete after processing.
  3. Episode contents (audio/video) will publish! the episode when the status becomes complete after processing.
  4. Episode images will publish! the episode when the status becomes complete after processing.
  5. The release episodes cron job will look for any scheduled episodes with published_at < updated_at and call .publish on the podcast.
    • TODO: that updated_at logic makes my head hurt

@cavis cavis self-assigned this Jul 26, 2023
@cavis cavis merged commit f298588 into main Jul 26, 2023
1 check passed
@cavis cavis deleted the fix/publish_podcast_after_change branch July 26, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants