Shield Activity Support #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panleone
force-pushed
the
nullifier_map
branch
2 times, most recently
from
ae2921a
to
61b6f01
Compare
panleone
changed the title
Duddino
requested changes
Oct 7, 2024
Duddino
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
utACK, clear to merge when PIVX-Labs/MyPIVXWallet#416 gets approved as well
panleone
force-pushed
the
nullifier_map
branch
from
438fb04
to
1f3aaa7
Compare
|
rebased to get rid of the git merge commit. You can check that the diff is trivial with
and check the files modified by this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is needed to support shield activity on MPW, it is divided in 4 main parts:
SimplifiedNotewhich is the structure we are actually going to send to MPWf: nullifier --> SimplifiedNote. In this way we can decrypt aShieldSpentonly by its nullifier.decryptTransactionOutputswhich tries to decrypt theShieldOutputof a transaction and returns their simplified version