Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use union merge driver for .toml files #303

Merged
merged 2 commits into from
Mar 7, 2024
Merged

Conversation

Duddino
Copy link
Member

@Duddino Duddino commented Feb 27, 2024

Abstract

Most .toml conflicts are due to two PRs adding different translations in the same point.
For example, #294 is currently conflicting with master:

shieldAddress = "" # Shield address
<<<<<<< tx-modal
noInputs = "" # No inputs
noOutputs = "" # No outputs
=======
cantShieldToExc = "" # This address does not support shield transfers
>>>>>>> master

With this PR we are telling git to accept both changes automatically in toml files, resulting in:

shieldAddress = "" # Shield address
noInputs = "" # No inputs
noOutputs = "" # No outputs
cantShieldToExc = "" # This address does not support shield transfers

Testing

Run the following commands, after having fetched my git remote:

  • git checkout 467432e187342b13e05730131cdad28e2af6567a (Tx description PR, might need to fetch the remote)
  • git merge master It should have a lot of locale conflicts
  • git merge --abort
  • git checkout ad0360d8c0dd0159561fa2bb0a9a87e3548e5d5e -- .gitattributes (Take this PR .gitattrubutes)
  • git commit -m "Test" Commit the changes so git doesn't complain about merging
  • git merge master Should merge cleanly now

Copy link

netlify bot commented Feb 27, 2024

Deploy Preview for cheery-moxie-4f1121 ready!

Name Link
🔨 Latest commit ad0360d
🔍 Latest deploy log https://app.netlify.com/sites/cheery-moxie-4f1121/deploys/65ddf29796e2890008a2edf2
😎 Deploy Preview https://deploy-preview-303--cheery-moxie-4f1121.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@panleone panleone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@JSKitty JSKitty merged commit 08361ef into PIVX-Labs:master Mar 7, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants