Commits on Sep 14, 2024

1. Squiz/MultiLineFunctionDeclaration: bug fix - skip over attributes …

   The sniff looks for `T_COMMA` tokens to find the start of the next parameter and skips over parenthesis sets and square brackets sets (like short arrays) to prevent mismatching on a `T_COMMA` which is not a parameter separator.
   
   This logic did not take parameter attributes into account, which can contain multiple comma-separated attributes, so should also be skipped over.
   
   Fixed now. Includes plenty of tests.
   
   Also includes minor stability fix for the parentheses/square brackets skipping.
   
   Notes:
   * It could be argued that the sniff should use the `File::getMethodParameters()` method to do the parameter parsing instead. This could be done in a future iteration, but will need to be evaluated carefully for side-effects.
   * This sniff extends the PEAR `FunctionDeclaration` sniff. It has been verified that that sniff is not affected by this bug.
   
   Fixes 608

   

   jrfnl committed Sep 14, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for f39847a
   • Browse repository at this point

   Copy the full SHA

   f39847a View commit details

   Browse the repository at this point in the history