Generic/UselessOverridingMethod: improve handling of PHP open/close tags between statements #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
54 tasks
…ags between statements This change prevents an edge-case false negative where a `parent::method()` function call statement ended by a PHP close tag without any "function content" of note after it, would not be reported as a useless overriding method. Includes unit tests. Related to 552
jrfnl
force-pushed
the
feature/552-generic-uselessoverridingmethod-bugfix-close-tag
branch
from
c98adfd
to
7642636
Compare
|
Rebased without changes to get this ready for merge tomorrow. |
jrfnl
deleted the
feature/552-generic-uselessoverridingmethod-bugfix-close-tag
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change prevents an edge-case false negative where a
parent::method()function call statement ended by a PHP close tag without any "function content" of note after it, would not be reported as a useless overriding method.Includes unit tests.
Suggested changelog entry
Generic.CodeAnalysis.UselessOverridingMethod: prevent edge case false negative when the call to the parent method would end on a PHP close tag.
Related issues/external references
Related to #552
Types of changes