Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests/TypeIntersectionTest: use named data sets and other tweaks #270

Merged
merged 2 commits into from
Jan 14, 2024
Merged

Tests/TypeIntersectionTest: use named data sets and other tweaks #270

merged 2 commits into from
Jan 14, 2024

Commits on Jan 14, 2024

  1. Tests/TypeIntersectionTest: fix order of tests 

    The test order in the test case file was at times confusing (by the looks of it caused by incorrect merge conflict resolution, which hasn't kept tests which were grouped together, together).

Fixed now.
    @jrfnl
    jrfnl committed Jan 14, 2024
    Configuration menu
    Copy the full SHA
    140ce8f View commit details
    Browse the repository at this point in the history

  2. Tests/TypeIntersectionTest: use named data sets 

    With non-named data sets, when a test fails, PHPUnit will display the number of the test which failed.

With tests which have a _lot_ of data sets, this makes it _interesting_ (and time-consuming) to debug those, as one now has to figure out which of the data sets in the data provider corresponds to that number.

Using named data sets makes debugging failing tests more straight forward as PHPUnit will display the data set name instead of the number.
Using named data sets also documents what exactly each data set is testing.

Includes making the data type in the docblock more specific.
    @jrfnl
    jrfnl committed Jan 14, 2024
    Configuration menu
    Copy the full SHA
    477b13f View commit details
    Browse the repository at this point in the history