Merge pull request #628 from PHPCSStandards/feature/ghactions-improve…

…-scripts GH Actions: always quote variables
PHPCSStandards · Oct 13, 2024 · 0e743df · 0e743df
2 parents 2e3c58b + 78eeee0
commit 0e743df
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 11 deletions.
diff --git a/.github/workflows/happy-new-year.yml b/.github/workflows/happy-new-year.yml
@@ -35,15 +35,15 @@ jobs:
  - name: Set branches to use
  id: branches
  run: |
- echo "BASE=master" >> $GITHUB_OUTPUT
- echo "PR_BRANCH=feature/squiz-filecomment-update-copyright-year" >> $GITHUB_OUTPUT
+ echo "BASE=master" >> "$GITHUB_OUTPUT"
+ echo "PR_BRANCH=feature/squiz-filecomment-update-copyright-year" >> "$GITHUB_OUTPUT"
 
  # Using "Tomorrow" to prevent accidentally getting last year if the server is not using UTC.
  - name: Grab the new year
  id: year
  run: |
- echo "PREVIOUS_YEAR=$(date --date="last month" -u "+%Y")" >> $GITHUB_OUTPUT
- echo "NEW_YEAR=$(date --date="tomorrow" -u "+%Y")" >> $GITHUB_OUTPUT
+ echo "PREVIOUS_YEAR=$(date --date="last month" -u "+%Y")" >> "$GITHUB_OUTPUT"
+ echo "NEW_YEAR=$(date --date="tomorrow" -u "+%Y")" >> "$GITHUB_OUTPUT"
 
  - name: "Debug info: Show years"
  run: "echo current year: ${{ steps.year.outputs.NEW_YEAR }} - previous year: ${{ steps.year.outputs.PREVIOUS_YEAR }}"

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -119,11 +119,11 @@ jobs:
  # Set the "short_open_tag" ini to make sure specific conditions are tested.
  # Also turn on error_reporting to ensure all notices are shown.
  if [[ ${{ matrix.custom_ini }} == true && "${{ matrix.php }}" == '5.5' ]]; then
- echo 'PHP_INI=error_reporting=-1, display_errors=On, date.timezone=Australia/Sydney, short_open_tag=On, asp_tags=On' >> $GITHUB_OUTPUT
+ echo 'PHP_INI=error_reporting=-1, display_errors=On, date.timezone=Australia/Sydney, short_open_tag=On, asp_tags=On' >> "$GITHUB_OUTPUT"
  elif [[ ${{ matrix.custom_ini }} == true && "${{ matrix.php }}" == '7.0' ]]; then
- echo 'PHP_INI=error_reporting=-1, display_errors=On, date.timezone=Australia/Sydney, short_open_tag=On' >> $GITHUB_OUTPUT
+ echo 'PHP_INI=error_reporting=-1, display_errors=On, date.timezone=Australia/Sydney, short_open_tag=On' >> "$GITHUB_OUTPUT"
  else
- echo 'PHP_INI=error_reporting=-1, display_errors=On' >> $GITHUB_OUTPUT
+ echo 'PHP_INI=error_reporting=-1, display_errors=On' >> "$GITHUB_OUTPUT"
  fi
 
  - name: Install PHP
@@ -215,11 +215,11 @@ jobs:
  # Set the "short_open_tag" ini to make sure specific conditions are tested.
  # Also turn on error_reporting to ensure all notices are shown.
  if [[ ${{ matrix.custom_ini }} == true && "${{ startsWith( matrix.php, '5.' ) }}" == true ]]; then
- echo 'PHP_INI=error_reporting=-1, display_errors=On, date.timezone=Australia/Sydney, short_open_tag=On, asp_tags=On' >> $GITHUB_OUTPUT
+ echo 'PHP_INI=error_reporting=-1, display_errors=On, date.timezone=Australia/Sydney, short_open_tag=On, asp_tags=On' >> "$GITHUB_OUTPUT"
  elif [[ ${{ matrix.custom_ini }} == true && "${{ startsWith( matrix.php, '7.' ) }}" == true ]]; then
- echo 'PHP_INI=error_reporting=-1, display_errors=On, date.timezone=Australia/Sydney, short_open_tag=On' >> $GITHUB_OUTPUT
+ echo 'PHP_INI=error_reporting=-1, display_errors=On, date.timezone=Australia/Sydney, short_open_tag=On' >> "$GITHUB_OUTPUT"
  else
- echo 'PHP_INI=error_reporting=-1, display_errors=On' >> $GITHUB_OUTPUT
+ echo 'PHP_INI=error_reporting=-1, display_errors=On' >> "$GITHUB_OUTPUT"
  fi
 
  - name: Install PHP
@@ -255,7 +255,7 @@ jobs:
  - name: Grab PHPUnit version
  id: phpunit_version
  # yamllint disable-line rule:line-length
- run: echo "VERSION=$(vendor/bin/phpunit --version | grep --only-matching --max-count=1 --extended-regexp '\b[0-9]+\.[0-9]+')" >> $GITHUB_OUTPUT
+ run: echo "VERSION=$(vendor/bin/phpunit --version | grep --only-matching --max-count=1 --extended-regexp '\b[0-9]+\.[0-9]+')" >> "$GITHUB_OUTPUT"
 
  - name: "DEBUG: Show grabbed version"
  run: echo ${{ steps.phpunit_version.outputs.VERSION }}