Split from xclim #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome, new contributor! It appears that this is your first Pull Request. To give credit where it's due, we ask that you add your information to the
Please make sure you've read our contributing guide. We look forward to reviewing your Pull Request shortly ✨ |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
coxipi
commented
Oct 24, 2024
coxipi
commented
Oct 24, 2024
|
@coxipi I believe the new failures are due to the latest |
Zeitsperre
reviewed
Oct 30, 2024
…into split_from_xclim
fast-forward cookiecutter
Zeitsperre
reviewed
Nov 5, 2024
| @@ -61,6 +61,6 @@ commands_pre = | |||
| pip list | |||
| pip check | |||
| commands = | |||
| pytest --cov | |||
| pytest xsdba {posargs} | |||
There was a problem hiding this comment.
This is failing because there is no xsdba folder in the top-level (it lives in src). Also, pytest is looking for tests.
The --cov argument takes a keyword (xsdba) to know that the relevant module ton look at is the library. --cov on its own is an error.
Suggested change
| pytest xsdba {posargs} | |
| pytest {posargs} |
| @@ -42,9 +40,11 @@ commands = | |||
| allowlist_externals = | |||
| make | |||
|
|
|||
| [pytest] | |||
| addopts = --color=yes --cov | |||
There was a problem hiding this comment.
Suggested change
| addopts = --color=yes --cov | |
| addopts = --color=yes --cov=xsdba |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
number) and pull request (:pull:number) has been added.What kind of change does this PR introduce?
sdbafromxclim. Mostly all tests that previously existed are passed in this separate module. Functions and tests that we very climate specific were removed.adjustment.pyDoes this PR introduce a breaking change?
N/A
Other information:
Important parts that still need attention:
units.pycopies a lot of stuff and the end ofbase.py. Is that all right?