-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.0.0 #119
Conversation
@nbuffon , how to finalize these works? I review? We close without merging? |
|
Signed-off-by: Nicolas Buffon <[email protected]>
Signed-off-by: Nicolas Buffon <[email protected]>
Signed-off-by: Nicolas Buffon <[email protected]>
Signed-off-by: Nicolas Buffon <[email protected]>
Using [Criterion][1] to add benchmarks in `benches` folder Note that `benches` folder need to be copied in the build Docker image otherwise the build fails [1]: https://github.com/bheisler/criterion.rs Signed-off-by: Nicolas Buffon <[email protected]> Signed-off-by: Nicolas Buffon <[email protected]>
Signed-off-by: Nicolas Buffon <[email protected]>
Renamed GeoExtension into Quadkey because it is what it is Move the whole thing into mobility mod as quadtree is a positioning solution Signed-off-by: Nicolas Buffon <[email protected]>
Signed-off-by: Nicolas Buffon <[email protected]>
Signed-off-by: Nicolas Buffon <[email protected]>
Using the name Quadtree, despite not being a real implementation of it, to match the mod and because we don't need a specific implementation of it yet or any parsing performance specificaly This could anyway be a good thing to bring a real tree implementation in the future Signed-off-by: Nicolas Buffon <[email protected]>
Signed-off-by: Nicolas Buffon <[email protected]>
This function returns the current timestamp in milliseconds Signed-off-by: Nicolas Buffon <[email protected]>
Signed-off-by: Nicolas Buffon <[email protected]>
Signed-off-by: Nicolas Buffon <[email protected]>
Most part of the code has been commented in exchange.rs because it uses structs that will be moved or implemented in further commits Signed-off-by: Nicolas Buffon <[email protected]>
Signed-off-by: Nicolas Buffon <[email protected]>
Signed-off-by: Nicolas Buffon <[email protected]>
Signed-off-by: Nicolas Buffon <[email protected]>
Signed-off-by: Nicolas Buffon <[email protected]>
Signed-off-by: Nicolas Buffon <[email protected]>
This module describes the ETSI messages which are intended to be exchanged It also provides the functions to converts data from SI units to ETSI fancy ones Signed-off-by: Nicolas Buffon <[email protected]>
Signed-off-by: Nicolas Buffon <[email protected]>
Signed-off-by: Nicolas Buffon <[email protected]>
This declaration is unnecessary as Cargo will look for this path by default using the `name` field It was also creating a warning at build about `unused manifest key: example.0.src` Signed-off-by: Nicolas Buffon <[email protected]>
Switch to MQTTv5 using the corresponding module from rumqttc crate Signed-off-by: Nicolas Buffon <[email protected]>
Enabling the `websocket` feature ead to MqttOptions losing `Send` trait impl which made it unmovable to Tokio tasks (both our Configuration struct and rumqttc's EventLoop were impacted) This has been fixed in 0.24 release Signed-off-by: Nicolas Buffon <[email protected]>
geo_routing enables mobility Signed-off-by: Nicolas Buffon <[email protected]>
MqttClient and MqttRouter visibility was limited to the crate as they were not meant to be exposed initially Now that we need to be able to do MQTT without mobiity features, removing the crate visibility restriction Signed-off-by: Nicolas Buffon <[email protected]>
Signed-off-by: Nicolas Buffon <[email protected]>
New example illustrating how to connect to a broker and treat messages without using the mobility feature Signed-off-by: Nicolas Buffon <[email protected]>
Signed-off-by: Nicolas Buffon <[email protected]>
Requiring HTTP related features from open telemetry dependencies As we use HTTP also add `reqwest` and `http` dependencies Signed-off-by: Nicolas Buffon <[email protected]>
Module to provide higher level OpenTelemetry span management functions Signed-off-by: Nicolas Buffon <[email protected]>
Restrict telemetry module to telemetry feature Signed-off-by: Nicolas Buffon <[email protected]>
Signed-off-by: Nicolas Buffon <[email protected]>
Impl Injector and Extractor traits for Packet to allow it to be used by TraceContextPropagator for W3C context storage/retrieval Use PublishProperties to store W3C context as MQTT property Signed-off-by: Nicolas Buffon <[email protected]>
Signed-off-by: Nicolas Buffon <[email protected]>
This unit test was failing since the beginning but waas missed because only `cargo test` was launched and as geo_topic module is restricted to `geo_routing` feature it requires `cargo test --feature geo_routing` to be launched Signed-off-by: Nicolas Buffon <[email protected]>
Signed-off-by: Nicolas Buffon <[email protected]>
Signed-off-by: Nicolas Buffon <[email protected]>
SimpleExporter sends Span once they end and does not seem to be compatible from Tokio runtime Switch to BatchedSpanProcessor using Tokio runtime to fix the runtime errors when using mobility pipeline and to enhance performances Signed-off-by: Nicolas Buffon <[email protected]>
There is a conflict on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a conflict on THIRD-PARTY.md
. Please rebase and resolve the conflict before pushing again.
Sure, I already did the rebase, I was waiting for a cue from your side to push it |
It is only used in the `mobility` feature and then raises a warning at build when the feature is not enabled Its content does no more than Default trait implementation, so replace any existing use by `MqttRouter::default()` Signed-off-by: Nicolas Buffon <[email protected]>
Two in-crate functions are unused yet because the high level function that the library will provide are not implemented yet, see [Github issue][1] [1]: #131 Signed-off-by: Nicolas Buffon <[email protected]>
c8fef4b
to
68b2b77
Compare
There is no longer a single binary packed with the Rust crate The whoe project architecture has been switched to a library with examples In the process the Dockerfile was modified and does not describe any image that can be launched anymore Simply remove that step from the workflow has it was checking the correct start of such an image Signed-off-by: Nicolas Buffon <[email protected]>
I added 3 new commits, that you can review, to fix the workflow issue, and the build warnings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- No workflow in error
- json_counter example works
- copycat example works
- telemetry example works
No more warning during build.
What's new
Rust
closes Fix ./its-client: No such file or directory #19
closes Worflow tries (and fails) to publish rust packages when version is not updated #23
json_counter
for MQTT client without mobility functionnalitytelemetry
for OpenTelemetry clientHow to test
Check workflow status
=> None must have failed
Test MQTT example
=> The example must run successfully and log about message reception
Test mobility example
Edit the configuration to limit the analysis threads to 1
Launch the example
=> The example must run successfully
Send a CAM message
=> The received CAM is scheduled for copy
Wait a few seconds (more than 3)
Send a second CAM
=> Second CAM is scheduled for copy
=> Previous received CAM is sent on inQueue
Test telemetry example
example/config.ini
file to uncomment and fill the[telemetry]
section to fit your OTLP collector configuration=> You must see the corresponding traces that the example logged about