Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check duration, addressing #66 #114

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Check duration, addressing #66 #114

wants to merge 4 commits into from

Conversation

seankross
Copy link
Contributor

@stefaniebutland I'll work on this more this week, just wanted to give you a heads up this is in flight.

@seankross seankross marked this pull request as ready for review September 25, 2024 04:30
@seankross
Copy link
Contributor Author

Hey @stefaniebutland, let me know what you think of this:

# grab this version of kyber
pak::pak("openscapes/kyber@check-duration")

library(kyber)

registry_url <- "[the registry url]"
cohort_id <- "2024-noaa-a"

check_duration(registry_url = registry_url, 
               cohort_id = cohort_id, 
               call_number = 1)

check_duration(registry_url = registry_url, 
               cohort_id = cohort_id, 
               call_number = 2)

@stefaniebutland
Copy link
Member

Hi @seankross. Running this check confirmed that Call 2 durations, as expected, don't match. I think the issue is that kyber's calculated duration isn't accurate for Call 2; we won't necessarily use the check_duration function. Please see Julie's comment in the issue

registry_url <- "[the registry url]"
cohort_id <- "2024-nmfs-champions-a"
check_duration(registry_url = registry_url, 
                cohort_id = cohort_id, 
                call_number = 2)

output

ℹ Specified total duration: 90 minutes
ℹ Calculated total duration: 91 minutes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants