-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to edit certain users with two meetings #4205
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If Ann (the admin) is not allowed to edit the personal information and Ben (the edited user) has a gender selected then Ann cannot edit the Meeting specific information. I tested all personal information, the gender is the only attribute, which is doing that.
payload:
[
{
"action": "user.update",
"data": [
{
"id": 3,
"gender_id": 3,
"meeting_id": 2,
"vote_delegated_to_id": null,
"vote_delegations_from_ids": [],
"group_ids": [
8,
9
]
}
]
}
]
Co-authored-by: Bastian Rihm <[email protected]>
I cannot reproduce the problem.
@Elblinator can you give more info? |
What I did:
I just realised that the personal information mask is not correctly displayed there as well, I can imagine that this is the actual bug. The personal information mask is not disabled |
Okay, ty, I see the problem. I can reproduce the problem in main, too. |
These are two cases: |
I have talked to @hjanott , I want to ask for the editable fields with one presenter call. So there needs to be improvements. |
Added a version which uses the new get-user-editable fields presenter. This part of the code works. |
setTimeout(() => { | ||
this._userFormLoaded = true; | ||
}, 1000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use an actual check if the data is loaded.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The personal information fields are disabled too much:
all Scenarios are scenarios where the fields should be enabled:
-
There are two committees A and B
-
Committee A has meeting A1 and A2, A3
-
Committee B has meeting B1 and B2
-
And more
-
"A" is Meeting A1 with user.can update rights and in A2, B1 and B2 as admin and they are in different meetings from different committees without these rights
-
"B" is in meeting A1 and A2 as deli/default
-
"C" in meeting A1 and B1 as deli/default
-
"D" in meeting A1, A2 and B1 as deli/default
Resolve #3841
Only participant detail view.
Needs: OpenSlides/openslides-backend#2576
In the participant detail view it is checked by the
get_user_editable
presenter, if the operator can edit standard personal info fields. The fields are enabled then.