Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to edit certain users with two meetings #4205

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

reiterl
Copy link
Member

@reiterl reiterl commented Oct 2, 2024

Resolve #3841

Only participant detail view.
Needs: OpenSlides/openslides-backend#2576

In the participant detail view it is checked by the get_user_editable presenter, if the operator can edit standard personal info fields. The fields are enabled then.

@reiterl reiterl added this to the 4.2 milestone Oct 2, 2024
client/src/app/site/services/user.service.ts Outdated Show resolved Hide resolved
@bastianjoel bastianjoel removed their assignment Oct 4, 2024
Copy link
Member

@Elblinator Elblinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If Ann (the admin) is not allowed to edit the personal information and Ben (the edited user) has a gender selected then Ann cannot edit the Meeting specific information. I tested all personal information, the gender is the only attribute, which is doing that.

payload:

[
  {
    "action": "user.update",
    "data": [
      {
        "id": 3,
        "gender_id": 3,
        "meeting_id": 2,
        "vote_delegated_to_id": null,
        "vote_delegations_from_ids": [],
        "group_ids": [
          8,
          9
        ]
      }
    ]
  }
]

@Elblinator Elblinator assigned reiterl and unassigned Elblinator Oct 10, 2024
Co-authored-by: Bastian Rihm <[email protected]>
@reiterl
Copy link
Member Author

reiterl commented Oct 10, 2024

I cannot reproduce the problem.
I tried:

  1. create two meetings MA and MB
  2. create a gender G
  3. create an participant P1 who is in MA and MB with G
  4. create an meeting admin P2 in MA.
  5. Login as P2
  6. Move into MA, and try to change the group (meeting setting) of P1.
    => It works without problems.

@Elblinator can you give more info?

@reiterl reiterl assigned Elblinator and unassigned reiterl Oct 10, 2024
@Elblinator
Copy link
Member

What I did:

  1. make run-dev (meaning you have a meeting with A and B both as delegates)
  2. login as admin
  3. create new committee
  4. create new meeting in thenew committee
  5. Add (already existing users) A as admin and B
  6. Login as A and try editing B
  7. The personal information mask is not disabled and you cannot edit only the meeting specific information

I just realised that the personal information mask is not correctly displayed there as well, I can imagine that this is the actual bug. The personal information mask is not disabled

@Elblinator Elblinator assigned reiterl and unassigned Elblinator Oct 10, 2024
@reiterl
Copy link
Member Author

reiterl commented Oct 10, 2024

Okay, ty, I see the problem. I can reproduce the problem in main, too.

@reiterl
Copy link
Member Author

reiterl commented Oct 10, 2024

These are two cases:
A) 1 committee with 2 meetings
B) 2 committees with 1 meeting each
The B) case doesn't work as excepted and was wrong in main too. I will look at it.

@reiterl
Copy link
Member Author

reiterl commented Oct 11, 2024

I have talked to @hjanott , I want to ask for the editable fields with one presenter call. So there needs to be improvements.

@reiterl
Copy link
Member Author

reiterl commented Oct 15, 2024

Added a version which uses the new get-user-editable fields presenter. This part of the code works.
But I see a flickering Save button in the edit form. I will try to find the reason for this.

Comment on lines +333 to +335
setTimeout(() => {
this._userFormLoaded = true;
}, 1000);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use an actual check if the data is loaded.

@bastianjoel bastianjoel assigned reiterl and unassigned bastianjoel Oct 18, 2024
Copy link
Member

@Elblinator Elblinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The personal information fields are disabled too much:
all Scenarios are scenarios where the fields should be enabled:

  • There are two committees A and B

  • Committee A has meeting A1 and A2, A3

  • Committee B has meeting B1 and B2

  • And more

  • "A" is Meeting A1 with user.can update rights and in A2, B1 and B2 as admin and they are in different meetings from different committees without these rights

  • "B" is in meeting A1 and A2 as deli/default

  • "C" in meeting A1 and B1 as deli/default

  • "D" in meeting A1, A2 and B1 as deli/default

@Elblinator Elblinator removed their assignment Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow meetings admins to change personal information for certain users
3 participants