Disable FFmpeg hwaccel when APPIMAGE_BUILD is set #779
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in OpenShot/openshot-qt#4538, the hwaccel code in FFmpegReader/Writer should be completely disabled, when building for the Linux AppImages. This PR respects the CMake option 'APPIMAGE_BUILD', which we are already setting in the project server builds, and defines the symbol
USE_HW_ACCEL=0
for the build. The#ifdef
s around the hwaccel code will cause it to be omitted from the compiled classes entirely.Fixes OpenShot/openshot-qt#4538