Merge pull request #163 from OpenSLO/feature/threshold-metrics

default operator
OpenSLO · Sep 29, 2022 · 4710d14 · 4710d14
2 parents 27f7c4a + 31d3c3c
commit 4710d14
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/internal/pkg/convert/convert.go b/internal/pkg/convert/convert.go
@@ -234,10 +234,13 @@ func getN9Thresholds(o []v1.Objective, indicator v1.SLISpec) ([]nobl9v1alpha.Thr
 	var t []nobl9v1alpha.Threshold //nolint:prealloc
 	for _, v := range o {
 		v := v // local copy
-		// if the operator isn't nil, then assign it, otherwise keep it nil
+		// if the operator isn't nil, then assign it, otherwise use default
 		var operator *string
+		defaultOp := "lt"
 		if v.Op != "" {
 			operator = &v.Op
+		} else {
+			operator = &defaultOp
 		}
 
 		// if v.Value is set use that, otherwise default to 1