Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added rendering for PTC #77

Closed
wants to merge 1 commit into from

Conversation

JonathanBittner
Copy link
Contributor

Added support for rendering North American Positive Train Control in the
signal style.

Partially addresses #37

Added support for rendering North American Positive Train Control in the
signal style.
@JonathanBittner
Copy link
Contributor Author

JonathanBittner commented Apr 1, 2022

Longer explanation: added code to render railway:ptc=yes as purple (tram color from standard/infrastructure) and assign it equal rank with ETCS. I'm not tied to that color, feel free to suggest something different or suggest that the color/legend entry be shared with ETCS.

I took a look at the available tags here: the relevant tags are railway:acses, railway:ases, railway:etms, and railway:itcs, and railway:ptc. I did a tag usage survey and saw that railway:acses had 8 occurrences, and there were none for ases, etms, or itcs. There are currently 803 ways using railway:ptc. I added the railway:ptc tag to the 8 railway:asces nodes. There are several other PTC systems being approved including CBTC and e-ATC.

Most of the freight network has adopted I-ETMS (railway:etms). ITCS was installed on one Amtrak line in Michigan. ACSES II (railway:acses) is used by Amtrak on the Northeast Corridor, connected branches, and by several commuter authorities that also operate on Amtrak-owned lines. ASES II is used on several New Jersey Transit lines. One line in Maryland has both I-ETMS and ASCES II so the commuter operator could simply use I-ETMS on all of their lines.

It would be very complicated to add a color for each vendor's PTC implementation. Since most of these tags have never been used, it would be better to group everything under railway:ptc. If desired, a text layer could be added later to show the specific PTC implementation.

@DerDakon
Copy link
Contributor

Looks basically sane to me. Please rebase on current master.

@DerDakon DerDakon requested a review from a team September 25, 2022 10:45
Copy link
Collaborator

@Nakaner Nakaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

ptc-z8

@DerDakon
Copy link
Contributor

Please rebase to adapt to new changes in master. Tell us if you need any help.

@davide84
Copy link
Contributor

Hi! I took the liberty to do the rebase, unfortunately I had to open a different PR from my repo but I retained the original author. See #86.
Hope this way of doing things is useful :)

@JonathanBittner
Copy link
Contributor Author

Sorry, I don't have time to be active right now. Thanks to all who are pushing this through!

@Nakaner
Copy link
Collaborator

Nakaner commented Oct 28, 2022

Replaced by #86.

@Nakaner Nakaner closed this Oct 28, 2022
@DerDakon DerDakon added the style:signals signalling style label Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants