-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added rendering for PTC #77
Conversation
Added support for rendering North American Positive Train Control in the signal style.
Longer explanation: added code to render I took a look at the available tags here: the relevant tags are railway:acses, railway:ases, railway:etms, and railway:itcs, and railway:ptc. I did a tag usage survey and saw that railway:acses had 8 occurrences, and there were none for ases, etms, or itcs. There are currently 803 ways using railway:ptc. I added the railway:ptc tag to the 8 railway:asces nodes. There are several other PTC systems being approved including CBTC and e-ATC. Most of the freight network has adopted I-ETMS (railway:etms). ITCS was installed on one Amtrak line in Michigan. ACSES II (railway:acses) is used by Amtrak on the Northeast Corridor, connected branches, and by several commuter authorities that also operate on Amtrak-owned lines. ASES II is used on several New Jersey Transit lines. One line in Maryland has both I-ETMS and ASCES II so the commuter operator could simply use I-ETMS on all of their lines. It would be very complicated to add a color for each vendor's PTC implementation. Since most of these tags have never been used, it would be better to group everything under railway:ptc. If desired, a text layer could be added later to show the specific PTC implementation. |
Looks basically sane to me. Please rebase on current master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase to adapt to new changes in master. Tell us if you need any help. |
Hi! I took the liberty to do the rebase, unfortunately I had to open a different PR from my repo but I retained the original author. See #86. |
Sorry, I don't have time to be active right now. Thanks to all who are pushing this through! |
Replaced by #86. |
Added support for rendering North American Positive Train Control in the
signal style.
Partially addresses #37