-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request adding support for different train protection system types #37
Comments
Was also a bit thinking of how to actually do it. As it gets very much different systems, it would be nice to have an recallable, unbiased order. Possible differentiations which I see:
How to deal with already outdated systems / systems that will reach EOL in a few years? (Iwould like to use them as well in the system as some years is enough time) Some of those properties could also be translated in non-color information such as line thickness or hatching. What do you all think about it? |
Theoretically all of https://wiki.openstreetmap.org/wiki/OpenRailwayMap/Tagging#Train_protection_systems should be supported.
Radio would be wrong in this context because that isn't a train protection system.
The color is the biggest question but there are enough colors for all systems.
These are questions for the other repo but alphabetical would be the best choice.
Outdated systems should be removed from being rendered but systems that are near EOL but currently still in active use should be rendered just like active ones.
That's one way, the other is by using lighter colours like what is currently being used with ETCS, but the latter removes many colours that could be used for rendering additional train protection systems. |
I'd like to see some of the US systems added even if they have to share colors with some of the European systems. The US is somewhat complicated, however, with three or more flavors of Positive Train Control (ACSES II [Amtrak, NYC-area commuter lines], I-ETMS [freight network], ITCS [single Amtrak line in Michigan]) one area (Maryland) with two PTC systems overlaid, legacy Automatic Train Control cab signaling that can also be combined with PTC (optional with I-ETMS, required [I think] with ASCES II), plus some Automatic Train Stop (inductive) some of which is standalone, some being phased out, and some combined with PTC. I think the line with Ansaldo ASES was upgraded to ACSES II. Might be a good idea to pick one color for US PTC (could be shared with ETCS) and have the line labeled with the appropriate systems and addons, Automatic train stop [w/o PTC could share the color with PZB, perhaps with a notation for inductive vs mechanical (subways). Likewise areas without PTC but with Cab Signalling/Automatic Train Control could share the color with ATB. Add a color [purple?] for CBTC and automated operation. |
When sharing colours I would suggest to reuse them for somewhat similar systems, i.e. use reddish colors for systems that allow continuous influence while yellow is something that only has influence on a specific position. My personal preference would be to only reuse blue for such systems that are actually somewhat the same than ETCS (like one Chinese system) as it is also used somewhat worldwide. Using purple as an alternative color for a different, but similar systems sounds like a good idea to me. |
@DerDakon I don't know if sharing colours would be the best idea as it makes it indistinguishable when used next to each other like in Ethiopia where CTCS is used on the Ethio-Djibouti and ETCS on the Awash-Weldiya line. |
Good point. |
What about using something like HSV color system for different types? Like each individual types of signal system or train protection system (European, Chinese, etc.) got their different hue, then the color brightness increase as the system level increase aka being closer to fully automated. |
I think it would be easier to do text labels or a slight color variation. Leave dashing for lines under construction. |
Different casing or so is a nightmare as you can see by zooming in and out around here: https://www.openrailwaymap.org/?style=standard&lat=48.68620084610073&lon=9.321191310882568&zoom=15 In case there are 2 tracks the casings overlap so the line basically looks like solid color. |
Recently the French systems, the Italian system and the american PTC have been added to the render. As the only intercontinental coordination, at the moment I like that ETCS is blue and ATP is red, so in principle when zooming out each continent will have a clearly dominant color. This happened more or less by chance, but it could be considered as an official strategy when implementing the chinese CTCS (green?). |
Is CTCS just ETCS with a different brand? If not, I would like to ask you to find an unsed color (preferred) or to use a color of system not used in nearby countries. |
To my knowledge CTCS is to some extent based (at least, conceptually) on ETCS but it's not compatible and its development is independent. ETCS is rendered as blue, the ATP in USA as red/magenta; this was done to suggest orange or green as most distinguishable colors in case CTCS rendering is implemented. I would not worry about other European colors, there won't be any overlap and the continent is planned to become mostly ETCS in one decade. There is a little bit of green in South Korea, though (TVM???). I would say there's another issue regarding CTCS: many lines are rendered, and therefore tagged, as ETCS. Should they be moved to CTCS or is that another signalling variant? @LaoshuBaby are you just proposing a feature or would you like to submit a PR? |
CTCS and ETCS are similar, but not the same. For specific explanations, please refer to the explanation in https://www.openstreetmap.org/changeset/129927242 (it is in French, you may need a translation tool)
Yes, as you said, some of the ETCS shown in your figure above should be marked as CTCS (most of them were batch edited by the mapper of the above OSM changeset, but the China community has not had time to fix them yet), the discussion can be found at https:// t.me/OpenRailwayMap/19/812 (in Chinese)
As for me, I prefer to choose red color for CTCS (whether it is lighter or darker, such as "[TieShuiHong, meaning'red like molten iron')](http://zhongguose.com /#tieshuihong)"), but if maintainers has other color suggestions, I will give priority to the maintainers' suggestion
I will try to propose a PR, but if there is any error in my code, just treat it as if I just proposed a feature. |
I had some time this morning and I opened a PR: I think we can continue the discussion there to find a color. |
I mention again here my PR #118 which aims at adding once for all support for all train protection systems, and thereby solving this issue :) |
https://taginfo.openstreetmap.org/keys/railway%3Actcs
A Chinese version train protection system
https://taginfo.openstreetmap.org/keys/railway%3Acbtc#overview
The text was updated successfully, but these errors were encountered: