-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front, gateway: supporting launching front from outside the gateway reverse proxy #9726
Conversation
1540e2d
to
34dd9aa
Compare
34dd9aa
to
c2eacb6
Compare
c2eacb6
to
ec322b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm thanks for this one !
ec322b5
to
89fcb62
Compare
Signed-off-by: Élyse Viard <[email protected]>
bec89bc
to
b30124c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the front (not tested)
b30124c
to
3080564
Compare
f8ca796
to
f200be1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9726 +/- ##
============================================
- Coverage 42.43% 37.83% -4.60%
============================================
Files 1314 990 -324
Lines 105823 90920 -14903
Branches 3305 1176 -2129
============================================
- Hits 44902 34404 -10498
+ Misses 58968 56062 -2906
+ Partials 1953 454 -1499
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
e1541e1
to
32847e5
Compare
Signed-off-by: Élyse Viard <[email protected]>
32847e5
to
0b3c094
Compare
For the developers working on macOS it can be a real pain to launch the front in a local fashion. Since we require the front to be served through the gateway, we must do gymnastics to serve the dev front.
This set of changes aims to solve this by providing a way to use the front from outside the stack, making it serve locally while consuming the services on the remote service (inside the Docker VM on macOS or windows, for instance).
In order to test this, start the stack in non-host mode, shutdown the front container and on your
.env.local
add:Start the front locally, and it should work.