Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restored masked scaled dot attention #2542

Merged
merged 1 commit into from
Dec 29, 2023
Merged

Restored masked scaled dot attention #2542

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions onmt/modules/multi_headed_attn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,6 +439,7 @@ def forward(
if (
step == 0
or not self.flash2
or self.self_attn_type != "scaled-dot-flash"
or self.max_relative_positions not in [0, -1]
or query.size(0) > 128
or query.dtype != torch.float16
Expand Down Expand Up @@ -685,6 +686,8 @@ def forward(
scores = self.alibi(scores)

scores = scores.float()
if key_pad_mask is not None and mask is None:
mask = key_pad_mask.unsqueeze(1)

if mask is not None:
# not 100% necessary but expand to nb of heads
Expand Down
Loading