Fixed missing/wrong admin _setActiveMenu()

[sreichel]

Description (*)

Some sections are not correctly highlighted when active.

[fballiano]

when you take PRs from other repos you should at least mention them: MahoCommerce/maho#12

@sreichel fo you remember that you were accusing somebody of this same thing?

[sreichel]

Dear @fballiano,

these changes are based on this issue #4207 and aren't identical to yours.

On your repo: +131 −110 lines changed
Here: +49 −40

Btw ... i can see a lot of "OM PR xyz" at https://github.com/MahoCommerce/maho/commits/main/.

Have you left any credits?

For sure i'll leave credits when I should pick up your or anybody else work.

---

Edit 22/09:

You have removed the complete history, so it looks like all work was done by you? (https://github.com/MahoCommerce/maho/graphs/contributors)

[sreichel]

Removed offtopic. Backuped screenshot.

[kiatng]

As a reviewer of this PR, I acknowledge that this PR should credit @tmewes original MahoCommerce/maho#12, which is precedent to this one. @fballiano Thanks for pointing this out.

[sreichel]

Why? I wanted to fix the missing highlighting (#4207, #4208) and manually reviewed every link after i have seen that even with changed SCSS not all links were correct. Of course it looks similiar, b/c it cant be fixed in another way.

[kiatng]

I can explain my opinion: both issues (#4207, #4208) were dated Sep 18, which is later than MahoCommerce/maho#12, dated Sep 1. Even though you may have the same idea earlier, I and others do not know about it until Sep 18. I didn't know @tmewes PR, but now that I know, I acknowledge and credit him for his idea.

[edited]
Further, you wrote
> ... manually reviewed every link ...
It seems @tmewes PR inspired this PR. If this is true, I am not an expert on ethic, but in my heart, I feel crediting the original work should be made in this case.

I am sorry for incorrectly interpreting “manually reviewed every link”.

[sreichel]

I leave credits when a use others work ...

• PHP8: Fixes passing null to str_contains() #4203 (used Hanmacs suggestion)
• Fixed some typos #4200 (used another tool)
• Backport: Added unittest for date and datetime #4210 (refered to original PR)

If i had picked up @tmewes PR or got inspired by it, i'd at least had left a "thanks".

No Kia, I have no need to adorn myself with borrowed plumes.

[sreichel]

I am sorry for incorrectly interpreting “manually reviewed every link”.

My bad, sorry for misleading wording ... "every admin menu link".