uctAppName: Draft for Testcase and Remove/Disable as Not Used

* Extend Coverage: Include App Name * Cleanup: Remove uctAppName
OpenKNX · Jul 22, 2024 · 3a0e167 · 3a0e167
1 parent e71ad4e
commit 3a0e167
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/src/ConfigTransfer.script.js b/src/ConfigTransfer.script.js
@@ -6,7 +6,7 @@ var uctGenVer = "0.1.0";
 var uctGen = "uct";
 var uctAppId = uctVersionInformation[0];
 var uctAppVer = uctVersionInformation[1];
-var uctAppName = null;
+// var uctAppName = null;
 
 
 function uctBtnExport(device, online, progress, context) {
@@ -81,9 +81,11 @@ function uctCreateHeader(module, channel) {
     */
 
     var pathApp = [uctHexNumberStr(uctAppId), uctHexNumberStr(uctAppVer)];
+    /* TODO check inclusion of app name
     if (uctAppName) {
         pathApp.push(uctAppName);
     }
+    */
 
     var moduleVersion = uctChannelParams[module].version;
     var pathModule = [

diff --git a/test/ConfigTransfer.test.js b/test/ConfigTransfer.test.js
@@ -628,6 +628,14 @@ describe('Header', () => {
             expect(uctCreateHeader("TXS", 6)).toBe("OpenKNX,cv1,0xAF42:0x23/TXS:0x17/6");
             expect(uctCreateHeader("TXS", 78)).toBe("OpenKNX,cv1,0xAF42:0x23/TXS:0x17/78");
         });
+        /*
+        it.skip("[NOT used yet] could include application name", () => {
+            const SAVE_uctAppName = cts.uctAppName;
+            cts.uctAppName = "OAM-Example";
+            expect(uctCreateHeader("TXS", 42)).toBe("OpenKNX,cv1,0xAF42:0x23:OAM-Example/TXS:0x17/42");
+            cts.uctAppName = SAVE_uctAppName;
+        });
+        */
     });
 
     describe('uctParseHeader(headerStr)', () => {

diff --git a/test/js_suffix.txt b/test/js_suffix.txt
@@ -10,7 +10,7 @@ module.exports = {
     uctGen,
     uctAppId,
     uctAppVer,
-    uctAppName,
+    // uctAppName,
 
     // functions
     uctSerializeParamValue,