Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#806 Support custom ClassLookup in WireTypeConverter #807

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

maxim-ponomarev
Copy link
Contributor

No description provided.

@yevgenp yevgenp force-pushed the #806-Support-custom-ClassLookup-in-WireTypeConverter branch from 95d5159 to 05fa50e Compare January 30, 2024 14:22
@yevgenp
Copy link
Contributor

yevgenp commented Jan 30, 2024

@maxim-ponomarev I've adjusted the test (as per YamlWire specs). Please verify if that's acceptable.

@yevgenp yevgenp force-pushed the #806-Support-custom-ClassLookup-in-WireTypeConverter branch from 05fa50e to 609b4be Compare January 30, 2024 20:20

public class UnknownClassLookup implements ClassLookup {
public static final CachedCompiler CACHED_COMPILER =
new CachedCompiler(Jvm.isDebug() ? new File(OS.getTarget(), "generated-test-sources") : null, null);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class should be moved to test sources or target has to be adjusted respectively.

Copy link

sonarcloud bot commented Jan 30, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
72.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@peter-lawrey
Copy link
Member

c.f. #823

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants