reduce max realtime priority to 90 instead of 99 ;)

OpenHD · Feb 19, 2024 · de646b4 · de646b4
1 parent 3c13d70
commit de646b4
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/executables/benchmark.cpp b/executables/benchmark.cpp
@@ -199,8 +199,7 @@ int main(int argc, char *const *argv) {
   int opt;
   Options options{};
   print_optimization_method();
-  SchedulingHelper::set_thread_params_max_realtime();
-  SchedulingHelper::print_current_thread_priority("TEST_MAIN");
+  SchedulingHelper::set_thread_params_max_realtime("TEST_MAIN");
 
   while ((opt = getopt(argc, argv, "s:k:p:x:t:")) != -1) {
     switch (opt) {

diff --git a/wifibroadcast/HelperSources/SchedulingHelper.hpp b/wifibroadcast/HelperSources/SchedulingHelper.hpp
@@ -30,11 +30,15 @@ static void print_current_thread_priority(const std::string& name) {
 }
 
 // this thread should run as close to realtime as possible
-static void set_thread_params_max_realtime(const std::string& tag="") {
+// https://youtu.be/NrjXEaTSyrw?t=647
+// COMMENT: Please don't ever use 99 for your application, there are some kernel threads that run at 99 that are really important
+// So ... lets use 90 for now
+static void set_thread_params_max_realtime(const std::string& tag,const int priority=90) {
   pthread_t target=pthread_self();
   int policy = SCHED_FIFO;
   sched_param param{};
-  param.sched_priority = sched_get_priority_max(policy);
+  //param.sched_priority = sched_get_priority_max(policy);
+  param.sched_priority=priority;
   auto result = pthread_setschedparam(target, policy, &param);
   if (result != 0) {
     std::stringstream ss;