Improving code efficiency by errors from cppcheck

avogadro/core/array.h

@@ -44,15 +44,18 @@ class ArrayRefContainer
   explicit ArrayRefContainer(const size_t n,
                              const ValueType& value = ValueType())
     : m_ref(1), data(n, value)
-  {}
+  {
+  }
 
   ArrayRefContainer(const ArrayRefContainer& other) : m_ref(1), data(other.data)
-  {}
+  {
+  }
 
   template <typename InputIterator>
   ArrayRefContainer(InputIterator first, InputIterator last)
     : m_ref(1), data(first, last)
-  {}
+  {
+  }
 
   // Increment the reference count.
   void reref() { ++m_ref; }
@@ -118,19 +121,18 @@ class Array
 
   explicit Array(const size_t n, const ValueType& value = ValueType())
     : d(new Container(n, value))
-  {}
+  {
+  }
 
   template <typename InputIterator>
   Array(InputIterator first, InputIterator last) : d(new Container(first, last))
-  {}
-
-  /** Copy constructor, note the copy made of the internal data of other. */
-  Array(const Array& other)
   {
-    other.d->reref();
-    d = other.d;
   }
 
+  /** Copy constructor, note the copy made of the internal data of other. */
+  Array(const Array& other) : d(new Container(*other.d)) {}
+  //'d' is allocated new memory and a deep copy is one
+
   ~Array();
 
   /**