Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements in angleiterator.cpp/h files by using cppcheck #1368

Closed
wants to merge 4 commits into from
Closed

Improvements in angleiterator.cpp/h files by using cppcheck #1368

wants to merge 4 commits into from

Commits on Oct 10, 2023

  1. Changed a converting constructor to being explicit during its declara… 

    …tion

Class 'AngleIterator' has a constructor with 1 argument that is not explicit. Such, so called 'Converting constructors', should in general be explicit for type safety reasons as that prevents unintended implicit conversions.

Signed-off-by: Surajjalpun2002 <[email protected]>
    @Surajjalpun2002
    Surajjalpun2002 committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    8de46e2 View commit details
    Browse the repository at this point in the history

  2. Removed unnecessary part of the condition 

    The use of valid here is unnecessary and doesn't have any effect because it's always false

Condition valid is always false

Signed-off-by: Surajjalpun2002 <[email protected]>
    @Surajjalpun2002
    Surajjalpun2002 committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    9dee21f View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2023

  1. used clang-format to format the document 

    Signed-off-by: Surajjalpun2002 <[email protected]>
    @Surajjalpun2002
    Surajjalpun2002 committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    3bc987b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'OpenChemistry:master' into master

    @Surajjalpun2002
    Surajjalpun2002 authored Oct 11, 2023
    Configuration menu
    Copy the full SHA
    35c5ee0 View commit details
    Browse the repository at this point in the history