Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotation in Manipulation Tool pane is not calculated relative to the expected centres #1755

Open
matterhorn103 opened this issue Oct 29, 2024 · 4 comments

Comments

@matterhorn103
Copy link
Contributor

Currently the Manipulation Tool offers translation and rotation as transformations that can be mathematically specified. In all cases the only atoms transformed are those currently selected.

For the rotation the user is offered the ability to select the centre that the rotation should be with respect to. Two options are available: "Origin" and "Geometry".

Unfortunately these are misnomers. When "Origin" is selected, the rotation is actually with respect to the geometric centre of the entire set of atoms in the "molecule" (file). When "Geometry" is selected, the rotation is with respect to the geometric centre of the current selection i.e. it rotates round it's own centre.

The current options should be renamed:

  1. "Origin" -> "Center of all atoms"
  2. "Geometry" -> "Center of current selection"

It would be nice if there were also other options, but I will open separate issues for them.

@ghutchis
Copy link
Member

Sounds like a wording change is needed. I haven't poked much into this code.

  • Origin (really 0,0,0)
  • Center of Molecule
  • Center of Selection

For the selection, it might also be nice to fit the hyperplane, and allow rotating around the normal to the centroid (e.g., to rotate a Cp ligand)

@matterhorn103
Copy link
Contributor Author

That gets into changing the axes used rather than the centre though, which seems a little complicated. Isn't it easier to have people align to the cartesian axes with the align tool and then rotate relative to the centre of the selection?

@ghutchis
Copy link
Member

ghutchis commented Nov 1, 2024

You can do that, but I think most people would be happy with an intuitive option when they select a bunch of atoms, that you can rotate around the centroid as an option.

It's a separate thing -- clearly the wording should change and a rotate around the true Cartesian origin is needed.

@matterhorn103
Copy link
Contributor Author

Does sound nice to have, definitely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants