Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to transform relative to specific atom and to true origin (or arbitrary point?) #1756

Closed
matterhorn103 opened this issue Oct 29, 2024 · 4 comments

Comments

@matterhorn103
Copy link
Contributor

matterhorn103 commented Oct 29, 2024

See #1755 for background.

Two options for the transformation centre used by the Manipulation Tool would be nice:

  1. "Specific atom" and then a drop-down list of atom indices
  2. A genuine "Origin" – the current "Origin" option doesn't actually result in rotation around the origin. Ideally the option to use 0,0,0 would be there.

(Alternatively to 2), the user could be given the ability to provide coordinates of the centre to use, which would cover the origin use case while being more flexible.)

@matterhorn103 matterhorn103 changed the title Add option to transform relative to true origin (or arbitrary point?) Add option to transform relative to true origin (or arbitrary point?) and to specific atom Oct 29, 2024
@matterhorn103 matterhorn103 changed the title Add option to transform relative to true origin (or arbitrary point?) and to specific atom Add option to transform relative to specific atom and to true origin (or arbitrary point?) Oct 29, 2024
@ghutchis
Copy link
Member

I think for the "specific atom" is just a special case of a selection - select one atom. So for ease-of-use, I'd rather not have a drop-down list of atom indices -- it could get quite long and then the user needs to know what atom 42 is (with a potential off-by-one error. ;-)

So I'm going to close this, since I mention the need for the "true origin" in #1755

@matterhorn103
Copy link
Contributor Author

But only the selected atoms get transformed, so it isn't possible to do it the way you suggest. The selection determines which atoms move, while the drop-down choices determine the centre they are moved with respect to. So you could select a single atom and then choose the "centre of selection" option, sure, but the result would be the single atom rotating relative to its own centre doesn't make a whole lot of sense.

@ghutchis
Copy link
Member

ghutchis commented Nov 1, 2024

Fair point. Let me think about this. I don't think a drop-down menu is the solution, but maybe it has a checkbox or option to move either the selected or unselected atoms.

@matterhorn103
Copy link
Contributor Author

I mean this was inspired by the bloke on the forum that I wrote that plugin for. I could imagine it being useful to be able to build a complex with two complicated ligands at axial positions and then put solvent ligands in the other coordination sites by rotating them round the metal atom centre, for example. So I was thinking how that sort of thing could be enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants