Default to CY24 and drop support for CY22 #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We abandoned cutting releases for this project, since it is not used by any downstream projects other than the main OpenAssetIO repo's CI tests, which always checks out `main` of this repo anyway. So just remove the release notes to reduce maintenance burden. Signed-off-by: David Feltell <[email protected]>
Part of OpenAssetIO/OpenAssetIO#1351. Remove support for changing the libstdc++ ABI version, since that was only necessary to support CY22. The updated `openassetio-build` Docker image conforms to CY24. So update usages of other `aswf` images to also conform to CY24. Remove workarounds for GitHub NodeJS version 20 default causing glibc incompatibilities with CY22 based containers, now that the image has been updated to CY24. Signed-off-by: David Feltell <[email protected]>
feltech
force-pushed
the
work/OpenAssetIO/1351-cy24
branch
5 times, most recently
from
28afb93
to
4a61197
Compare
Part of OpenAssetIO/OpenAssetIO#1351. Now that the `openassetio-build` container can support nodejs 20 (because glibc is new enough) we can update `actions/checkout`. This was an attempt to fix an error in GitHub CI ``` fatal: detected dubious ownership in repository at '/__w/OpenAssetIO-Test-CMake/OpenAssetIO-Test-CMake' ``` But it didn't work. See subsequent commit for workaround. Signed-off-by: David Feltell <[email protected]>
Part of OpenAssetIO/OpenAssetIO#1351. A recent change to git has exposed a bug in actions/checkout Signed-off-by: David Feltell <[email protected]>
feltech
force-pushed
the
work/OpenAssetIO/1351-cy24
branch
from
4a61197
to
280fc67
Compare
foundry-markf
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of OpenAssetIO/OpenAssetIO#1351.
Remove support for changing the libstdc++ ABI version, since that was only necessary to support CY22.
The updated
openassetio-buildDocker image conforms to CY24. So update usages of otheraswfimages to also conform to CY24.Remove workarounds for GitHub NodeJS version 20 default causing glibc incompatibilities with CY22 based containers, now that the image has been updated to CY24.