Allow initialize with unrecognized settings
#117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamCrooksFoundry
approved these changes
Jul 18, 2024
Part of OpenAssetIO/OpenAssetIO#1202. Disallowing unrecognized settings almost certainly precludes using BAL as part of a hybrid plugin, since it is likely the other constituent plugins will have different settings keys, and the hybrid plugin system will pass the same settings dict to all child plugins. As a result, the corresponding test in the API compliance suite will be removed from the core OpenAssetIO distribution, effectively relaxing the restriction that unrecognized keys should trigger an exception. So remove the check for unknown settings keys, and corresponding API compliance suite fixtures. Signed-off-by: David Feltell <[email protected]>
feltech
force-pushed
the
work/allowUnknownSettings
branch
from
e324c26
to
a914f98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of OpenAssetIO/OpenAssetIO#1202.
Disallowing unrecognized settings almost certainly precludes using BAL as part of a hybrid plugin, since it is likely the other constituent plugins will have different settings keys, and the hybrid plugin system will pass the same settings dict to all child plugins.
As a result, the corresponding test in the API compliance suite will be removed from the core OpenAssetIO distribution, effectively relaxing the restriction that unrecognized keys should trigger an exception.
So remove the check for unknown settings keys, and corresponding API compliance suite fixtures.