Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Zephyr, test against known working version and also the very latest on main #623

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

wmamills
Copy link
Collaborator

This PR brings open-amp up to parity with libmetal with regard to Zephyr CI testing

open-amp did not have the latest SDK discovery code nor the sdk install reduction of verbosity that were already in libmetal so this PR is a bit bigger than the one for libmetal but the end result is the same.

@wmamills wmamills requested a review from arnopo October 16, 2024 18:16
@wmamills wmamills marked this pull request as draft October 16, 2024 18:19
@wmamills
Copy link
Collaborator Author

@arnopo I have marked this as RFC until your PR goes in. I will then rebase and repush it and remove the RFC.
This PR should look the same but I will remove any merge conflicts with yours.

@wmamills wmamills self-assigned this Oct 16, 2024
Copy link
Collaborator

@arnopo arnopo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need few updates to take into account the update of the open-amp path introduce in #619

.github/workflows/continuous-integration.yml Show resolved Hide resolved
.github/workflows/continuous-integration.yml Outdated Show resolved Hide resolved
.github/workflows/heathcheck.yml Show resolved Hide resolved
.github/workflows/heathcheck.yml Outdated Show resolved Hide resolved
@arnopo arnopo added this to the Release V2024.10 milestone Oct 17, 2024
@wmamills wmamills force-pushed the wip-zephyr-ci branch 2 times, most recently from 13e6d4c to 7a41f27 Compare October 17, 2024 17:37
@wmamills wmamills requested a review from arnopo October 17, 2024 17:37
@wmamills wmamills marked this pull request as ready for review October 17, 2024 17:37
@wmamills
Copy link
Collaborator Author

@arnopo I rebased this on your CI update. As yours is not in main yet you will see your commits in this PR but they should disappear after you merge your PR. (Let me know if there is any issue with that.)

I took the "draft" mark off this now. It should be ready to go as soon as you accept your PR.

I went ahead and clones openamp-system-reference for the zephyr jobs to keep things consistent. The zephyr build step does not use the openamp-system-reference directory right now but it may in the future.

Copy link
Collaborator

@arnopo arnopo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to go
Please rebase to solve the merge conflict.

Reduce the console output for the Zephyr sdk install.
This now matches the intent of libmetal but uses the documented wget
option.

Signed-off-by: Bill Mills <[email protected]>
Allow Zephyr testing to either use locked known good values
or the very latest versions.

This brings open-amp to parity with libmetal.  Open-amp did not have the
SDK URL discovery code so that was added here as part of this.

The known good versions are best for PR checking as if the build fails
it is almost always the PR itself that broke it.

The latest version is good for periodically checking compatibility with
the very latest Zephyr changes.

For now we run both on pushes and PRs.

We also run main against the latest zephyr check weekly as a look ahead.

Signed-off-by: Bill Mills <[email protected]>
@wmamills
Copy link
Collaborator Author

Rebased and retested. Merge should be OK

@arnopo arnopo merged commit 3541b57 into OpenAMP:main Oct 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants