-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libmetal(cmake): set HAVE_STDATOMIC_H default true in NuttX platform #316
Conversation
cmake/depends.cmake
Outdated
|
||
# there is no need to use cmake include detection | ||
# under NuttX platform | ||
set(HAVE_STDATOMIC_H true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems not a good idea to force HAVE_STDATOMIC_H
here
what about ujsrt having
elseif (NOT "${CMAKE_SYSTEM_NAME}" STREQUAL "NuttX")
# TODO: fix for find_path() to detect stdatomic.h
# find_path (HAVE_STDATOMIC_H stdatomic.h)
set (_saved_cmake_required_flags ${CMAKE_REQUIRED_FLAGS})
set (CMAKE_REQUIRED_FLAGS "-c" CACHE STRING "")
check_include_files (stdatomic.h HAVE_STDATOMIC_H)
set (CMAKE_REQUIRED_FLAGS ${_saved_cmake_required_flags})
endif ()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NuttX platform supports builtin atomic and toolchain atomic.
The reason why CMAKE_REQUIRED_FLAGS cannot be used here is because this cache will destroy the CMake build of the integrated platform
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My point here is that HAVE_STDATOMIC_H
is probably defined in NuttX so the set(HAVE_STDATOMIC_H true)
seems redundant.
Exclude the cmake code related to CMAKE_REQUIRED_FLAGS
could be sufficient
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My point here is that
HAVE_STDATOMIC_H
is probably defined in NuttX so theset(HAVE_STDATOMIC_H true)
seems redundant. Exclude the cmake code related toCMAKE_REQUIRED_FLAGS
could be sufficient
HAVE_STDATOMIC_H
is the result of following this check check_include_files (stdatomic.h HAVE_STDATOMIC_H)
.
sure, thanks for your suggestion @arnopo .
Let's check for non-NuttX platforms in the if block
there is no need to use cmake include detection under NuttX platform Signed-off-by: xuxin19 <[email protected]>
b898112
to
3ba58ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to go.
I have fixed the commit subject that was not up to date |
there is no need to use cmake include detection under NuttX platform