cmake: platforms: xlnx: Update machine from 'zynqmp_' to 'xlnx_' #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Match update so that the cmake platform files are coupled to vendor and not SOC which is previously 'zynqmp_'. Signed-off-by: Ben Levinsky <[email protected]>
bentheredonethat
force-pushed
the
update-xlnx-cmake-files
branch
from
b15c31d
to
9c7ba51
Compare
| @@ -1,5 +1,5 @@ | |||
| set (CMAKE_SYSTEM_PROCESSOR "aarch64" CACHE STRING "") | |||
| set (MACHINE "zynqmp_a53" CACHE STRING "") | |||
There was a problem hiding this comment.
keep the alignement
There was a problem hiding this comment.
After addressing this comment it's good to go.
There was a problem hiding this comment.
but still not aligned
| @@ -1,5 +1,5 @@ | |||
| set (CMAKE_SYSTEM_PROCESSOR "arm" CACHE STRING "") | |||
| set (MACHINE "zynqmp_r5" CACHE STRING "") | |||
| set (MACHINE "xlnx_r5" CACHE STRING "") | |||
| @@ -1,5 +1,5 @@ | |||
| set (CMAKE_SYSTEM_PROCESSOR "arm" CACHE STRING "") | |||
| set (MACHINE "zynqmp_r5" CACHE STRING "") | |||
| set (MACHINE "xlnx_r5" CACHE STRING "") | |||
| @@ -1,5 +1,5 @@ | |||
| set (CMAKE_SYSTEM_PROCESSOR "aarch64" CACHE STRING "") | |||
| set (MACHINE "zynqmp_a53" CACHE STRING "") | |||
There was a problem hiding this comment.
but still not aligned
| @@ -1,5 +1,5 @@ | |||
| set (CMAKE_SYSTEM_PROCESSOR "aarch64" CACHE STRING "") | |||
| set (MACHINE "zynqmp_a53" CACHE STRING "") | |||
| set (MACHINE "xlnx_a53" CACHE STRING "") | |||
|
@bentheredonethat could you address the comment that we merge it for this release ( code freeze tomorrow evening)? |
He is on vacation right now. I am not sure if I can push changes in this PR. I will find a way if it's possible, I will do it. |
|
As discussed in RP call, this will be merged after release. CC: @arnopo, @bentheredonethat |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Match update so that the cmake platform files are coupled to vendor and not SOC which is previously 'zynqmp_'.