Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

work #50

Merged
merged 4 commits into from
Nov 18, 2022
Merged

work #50

merged 4 commits into from
Nov 18, 2022

Conversation

odscjames
Copy link
Collaborator

@odscjames odscjames commented Nov 17, 2022 •
edited
Loading

No description provided.

@odscjames odscjames self-assigned this Nov 17, 2022
@odscjames odscjames changed the title jsonschema_validation: Columns and fix wrong types work Nov 17, 2022
@odscjames odscjames force-pushed the 2022-11-17 branch 2 times, most recently from 2385e54 to 4e71f02 Compare November 18, 2022 09:04
Lathrisk
Lathrisk approved these changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@Lathrisk Lathrisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, besides one non-blocking comment

@odscjames odscjames merged commit 3c491e6 into ng Nov 18, 2022
@odscjames odscjames deleted the 2022-11-17 branch November 18, 2022 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lathrisk Lathrisk Lathrisk approved these changes

Assignees

@odscjames odscjames

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@odscjames @Lathrisk