Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download data / data conversion interface #24

Open
duncandewhurst opened this issue Nov 7, 2022 · 10 comments
Open

Download data / data conversion interface #24

duncandewhurst opened this issue Nov 7, 2022 · 10 comments

Comments

@duncandewhurst
Copy link
Contributor

duncandewhurst commented Nov 7, 2022

Current:

image

Proposed:

  • Success
    image
  • Partial failure
    image
  • Total failure
    image

Edit: Blue is panel-info, green is panel-success and red is panel-danger.

@duncandewhurst
Copy link
Contributor Author

Looks good on 2022-11-08. The outstanding actions are to:

  • Rename the box to 'Data conversion'
  • Add the introductory sentence

@duncandewhurst
Copy link
Contributor Author

I've updated the proposed interface to reduce the complexity of the logic for generating the introductory sentence and to create a space to report conversion errors:

image

@odscjames
Copy link
Collaborator

With regards to #63 and #67 (Spreadsheets being added back), can you say how the UI should be affected? Should there be a 4th box, or should we put it into the CSV box?

@lgs85
Copy link

lgs85 commented Dec 1, 2022

I think that we should use a separate box, to keep things consistent with the upload UI suggested by @duncandewhurst in #63

(as a side note we'll need to author some guidance on how XLSX is supported for conversion but not a publication format)

@duncandewhurst
Copy link
Contributor Author

I think that we should use a separate box, to keep things consistent with the upload UI suggested by @duncandewhurst in #63

Sounds good. Perhaps we can do two rows of two boxes. JSON and GeoJSON on the first row, CSV and Spreadsheet on the second row.

@odscjames
Copy link
Collaborator

4BOXES

??

@lgs85
Copy link

lgs85 commented Dec 2, 2022

I think this looks very good.

@duncandewhurst
Copy link
Contributor Author

Looks good to me. Thanks!

@odscjames
Copy link
Collaborator

Actually can I re-open - a very minor point, but it's possible for the Spreadsheet & GeoJSON conversion to cause a Python crash and in those cases currently the error won't be reported to the user in a nice way. We should put in the relevant box and turn box red, as suggested above.

@duncandewhurst
Copy link
Contributor Author

Sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants